-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added GitHub Actions CI #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added GitHub Actions CI #1455
Conversation
Great. Can you explain what's going on in some of the steps? It would be good to add some comments to the .travis.yml file. Also why the change to certbot? |
Line 13 in 4f64f51
Adds a hostname to the hosts file. Lines 14 to 15 in 4f64f51
Updates the apt package database and upgrades all currently installed packages. This is of course already done as part of the script, but doing it here significantly reduces the script runtime and makes sure Ubuntu and all the commands used by the script before it does the upgrade, are up to date. Line 16 in 4f64f51
Fixes a temporary issue with Travis CI and SpamAssassin. See here: travis-ci/travis-ci#8906 (comment). Line 19 in 4f64f51
Runs the script. Lines 20 to 23 in 4f64f51
Verifies that all the services are running by getting the HTTP headers. You can check for the 200 OK HTTP status code.
Line 24 in 4f64f51
Runs ShellCheck. See here. #1457 fixes most of the bugs that are found. This line allows contributors to verify that new bugs are not added in future commits. You can see the output of all these commands in the log here.
I can add the above as comments the
I was having issues with the script hanging on the Line 144 in 4f64f51
This change forces certbot to run non-interactively. See here.mailinabox/setup/management.sh Line 32 in 4f64f51
This change makes sure that all the required python dependencies are installed. |
4938a18
to
31fbca8
Compare
2de35d1
to
0e35484
Compare
0e35484
to
fd8edbf
Compare
@JoshData - Now that Travis CI is no longer free, I updated this PR to use GitHub Actions CI and test on Ubuntu 22.04. I also added comments to the workflow file as requested. |
Edit: This PR is now very outdated, but I would be happy to update it if there is ever interest in adding CI. Travis CI is no longer free, so we would need to use GitHub Actions CI instead.This pull request was originally part of #1435.