fix for redis 5.0 not handling hash to string implicitly anymore

maikokuppe · Oct 1, 2022 · 9d8c4f0 · 9d8c4f0
1 parent e133110
commit 9d8c4f0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/coverband/collectors/route_tracker.rb b/lib/coverband/collectors/route_tracker.rb
@@ -126,7 +126,7 @@ def report_routes_tracked
         @one_time_timestamp = true
         reported_time = Time.now.to_i
         @routes_to_record.to_a.each do |route|
-          redis_store.hset(tracker_key, route, reported_time)
+          redis_store.hset(tracker_key, route.to_s, reported_time)
         end
         @routes_to_record.clear
       rescue => e

diff --git a/test/coverband/collectors/route_tracker_test.rb b/test/coverband/collectors/route_tracker_test.rb
@@ -26,7 +26,7 @@ def setup
   test "track redirect routes" do
     store = fake_store
     route_hash = {controller: nil, action: nil, url_path: "path", verb: "GET"}
-    store.raw_store.expects(:hset).with(tracker_key, route_hash, anything)
+    store.raw_store.expects(:hset).with(tracker_key, route_hash.to_s, anything)
     tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir")
     payload = {
       request: OpenStruct.new(
@@ -42,7 +42,7 @@ def setup
   test "track controller routes" do
     store = fake_store
     route_hash = {controller: "SomeController", action: "index", url_path: "path", verb: "GET"}
-    store.raw_store.expects(:hset).with(tracker_key, route_hash, anything)
+    store.raw_store.expects(:hset).with(tracker_key, route_hash.to_s, anything)
     tracker = Coverband::Collectors::RouteTracker.new(store: store, roots: "dir")
     payload = {
       controller: "SomeController",