Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

88 remove old code #89

Merged
merged 4 commits into from
Nov 21, 2023
Merged

88 remove old code #89

merged 4 commits into from
Nov 21, 2023

Conversation

maho3
Copy link
Owner

@maho3 maho3 commented Nov 20, 2023

Removes various legacy code that was either used in early versions of ltu-ili or for private projects. Addresses the following tasks from Issue #88 :

  • Remove any temporary scripts from the main branch (e.g. the ones used for private projects).
  • Remove the Cosmology object and related tests.

Note, all this code is being removed from the main branch, but is preserved in branch backup_2023-20-11.

@maho3 maho3 marked this pull request as ready for review November 20, 2023 14:55
@maho3 maho3 mentioned this pull request Nov 20, 2023
19 tasks
Copy link
Collaborator

@DeaglanBartlett DeaglanBartlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except one small required change in tests/run.sh as we no longer create the file .coverage_utils so cannot merge this file with others when merging the coverage reports.

@maho3
Copy link
Owner Author

maho3 commented Nov 21, 2023

Note, this PR now also addresses "Make Nicolas' test notebooks consistent with the new version of ltu-ili, or otherwise remove them" from Issue #88 .

@maho3 maho3 merged commit 598cb83 into main Nov 21, 2023
@maho3 maho3 deleted the 88-remove-old-code branch November 21, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants