Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the selected item’s position is greater than 10, auto scrolling won’t happen for that item. #155

Open
santhosh-g-tz opened this issue Jul 18, 2024 · 8 comments
Labels
bug Something isn't working P3 Low Priority: A bug or a feature request we plan to work on in near future (default) review the issue needs to be reviewed again

Comments

@santhosh-g-tz
Copy link

santhosh-g-tz commented Jul 18, 2024

Hi,

The scroll navigation not working if the current selected item position is more than 10.
Note: my maxSuggestionsInViewPort is 10.
windows

var countries = [
  'United States',
  'Germany',
  'Canada',
  'United Kingdom',
  'France',
  'Italy',
  'Spain',
  'Australia',
  'India',
  'China',
  'Japan',
  'Brazil',
  'South Africa',
  'Mexico',
  'Argentina',
  'Russia',
  'Indonesia',
  'Turkey',
  'Saudi Arabia',
  'Nigeria',
  'Egypt',
];

SearchField<String>(
  maxSuggestionsInViewPort:10,
  suggestions: countries
      .map(
        (e) => SearchFieldListItem<String>(
      e,
      item: e,
      child: Padding(
        padding: const EdgeInsets.all(8.0),
        child: Text(e),
      ),
    ),
  ).toList(),
);
scrol.issue.mp4
@santhosh-g-tz santhosh-g-tz changed the title If the selected item’s position is greater than 10, scrolling won’t happen for that item. If the selected item’s position is greater than 10, auto scrolling won’t happen for that item. Jul 18, 2024
@maheshj01 maheshj01 added the in triage Issue is currently being triaged label Jul 18, 2024
@maheshj01
Copy link
Owner

Hello @santhosh-g-tz, Thanks for filing the issue. If I understand it right when the selected Items is out of view (not visible in the list) then arrows keys don't scroll to selected Item is that right?

@maheshj01 maheshj01 added the waiting for author waiting for author to respond back with more info label Jul 18, 2024
@santhosh-g-tz
Copy link
Author

@maheshmnj yes you are right.

@maheshj01
Copy link
Owner

Thanks for the confirmation! Btw if you are interested you are welcome to contribute, I usually try to fix things over the weekend. And Review PRs throughout the week.

@maheshj01 maheshj01 added bug Something isn't working P3 Low Priority: A bug or a feature request we plan to work on in near future (default) and removed waiting for author waiting for author to respond back with more info in triage Issue is currently being triaged labels Jul 19, 2024
maheshj01 added a commit that referenced this issue Jul 21, 2024
@maheshj01
Copy link
Owner

maheshj01 commented Jul 22, 2024

Fixed and Released in v1.0.7

cc: @santhosh-g-tz

@maheshj01 maheshj01 added the fixed The issue is fixed in new release label Jul 22, 2024
@santhosh-g-tz
Copy link
Author

@maheshj01 Thank you for your support. It works as expected.

@santhosh-g-tz
Copy link
Author

hi.
After the implementation of this new feature, the selected item is not being chosen.

@maheshj01
Copy link
Owner

I am seeing nuances of this issue I will leave this open for now until this is completely fixed part of #160

@maheshj01 maheshj01 reopened this Jul 23, 2024
@maheshj01
Copy link
Owner

Steps to reproduce

On the latest v1.0.8

  • Search
  • And select a suggestion with enter key

Not able to capture it 100% of the time.

@maheshj01 maheshj01 removed the fixed The issue is fixed in new release label Jul 23, 2024
@maheshj01 maheshj01 added the review the issue needs to be reviewed again label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 Low Priority: A bug or a feature request we plan to work on in near future (default) review the issue needs to be reviewed again
Projects
None yet
Development

No branches or pull requests

2 participants