Skip to content

Conversation

@mpdude
Copy link
Contributor

@mpdude mpdude commented Nov 29, 2025

This includes the fix from revoltphp/event-loop#110, and should make a PHP 8.5 deprecation notice go away that is displayed with the latest PHP versions:

Deprecated: Increment on non-numeric string is deprecated, use str_increment() instead in /composer-require-checker/vendor/revolt/event-loop/src/EventLoop/Internal/AbstractDriver.php on line 182

This includes the fix from revoltphp/event-loop#110, and should make a PHP deprecation notice go away that is displayed with the latest PHP versions:

> Deprecated: Increment on non-numeric string is deprecated, use str_increment() instead in /composer-require-checker/vendor/revolt/event-loop/src/EventLoop/Internal/AbstractDriver.php on line 182
mpdude added a commit to webfactory/docker-composer-require-checker that referenced this pull request Nov 29, 2025
PHP 8.5 has just been released, and it contains a change that makes
ComposerRequireChecker emit a PHP deprecation notice
(maglnet/ComposerRequireChecker#588).

By sticking with PHP 8.4 for the time being, we can avoid that notice.
@Ocramius
Copy link
Collaborator

let's add a conflict clause to composer.json

@mpdude
Copy link
Contributor Author

mpdude commented Nov 29, 2025

@Ocramius done

Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks @mpdude!

@Ocramius Ocramius merged commit ac5c359 into maglnet:4.19.x Nov 29, 2025
22 checks passed
@Ocramius Ocramius self-assigned this Nov 29, 2025
@Ocramius Ocramius added enhancement dependencies Pull requests that update a dependency file labels Nov 29, 2025
@Ocramius Ocramius added this to the 4.19.0 milestone Nov 29, 2025
@mpdude mpdude deleted the update-revolt-event-loop branch November 29, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants