Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export-ignore entries to .gitattributes #530

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Add export-ignore entries to .gitattributes #530

merged 2 commits into from
Mar 8, 2024

Conversation

VincentLanglet
Copy link
Contributor

Hi @Ocramius,

Seems like there is no export-ignore directive in this repo.
I tried to add some.

Copy link
Contributor

@fredden fredden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also add composer.lock to this list.

@VincentLanglet
Copy link
Contributor Author

We should probably also add composer.lock to this list.

Done

@Ocramius Ocramius added this to the 4.10.0 milestone Mar 8, 2024
@Ocramius
Copy link
Collaborator

Ocramius commented Mar 8, 2024

The simulated merges are really messing with CI here @_@

I think the patch is fine, just wondering about its build status: could you rebase on 4.10.x, please?

@Ocramius
Copy link
Collaborator

Ocramius commented Mar 8, 2024

Never mind, saw that #512 fixed this already.

Merging here - will fix-up if something breaks.

@Ocramius Ocramius merged commit 1773f8e into maglnet:4.10.x Mar 8, 2024
5 of 17 checks passed
@Ocramius Ocramius self-assigned this Mar 8, 2024
@Ocramius
Copy link
Collaborator

Ocramius commented Mar 8, 2024

Thanks @VincentLanglet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants