Skip to content

[WIP] Detect functions declared in the same file #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vudaltsov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Detect functions declared in the same file #193

vudaltsov wants to merge 2 commits into from

Conversation

@vudaltsov
Copy link

@vudaltsov vudaltsov commented Jul 11, 2020

Fixes #179

  • make test fail
  • fix the issue

@vudaltsov
Copy link
Author

vudaltsov commented Jul 11, 2020

I think, I found the problem.

https://github.com/nikic/PHP-Parser/blob/master/doc/component/Name_resolution.markdown

Unqualified function and constant names inside a namespace cannot be statically resolved. Inside a namespace Foo, a call to strlen() may either refer to the namespaced \Foo\strlen(), or the global \strlen(). Because PHP-Parser does not have the necessary context to decide this, such names are left unresolved. Additionally a namespacedName attribute is added to the name node.

This was referenced Nov 18, 2025
Closed
Merged
mpdude added a commit to webfactory/WebfactoryShortcodeBundle that referenced this pull request Nov 24, 2025
@mpdude
Switch from XML-based to PHP-based service configuration (#42)
94704d3 
XML-based service configuration has been deprecated since
symfony/symfony#60568 and will no longer be
supported in Symfony 8.0.

See also
https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration.

In order for ComposerRequireChecker to recognise where the functions
come from, we have to import them explicitly. At the same time,
PHP-CS-Fixer must not remove the import, which is actually superfluous.

X-Ref GromNaN/symfony-config-xml-to-php#29,
maglnet/ComposerRequireChecker#193 (comment)
mpdude added a commit to webfactory/WebfactoryHttpCacheBundle that referenced this pull request Nov 29, 2025
@mpdude
Switch from XML-based to PHP-based service configuration
4e549b8 
XML-based service configuration has been deprecated since symfony/symfony#60568 and will no longer be supported in Symfony 8.0.

See also https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration.

In order for ComposerRequireChecker to recognise where the functions come from, we have to import them explicitly. At the same time, PHP-CS-Fixer must not remove the import, which is actually superfluous.

X-Ref GromNaN/symfony-config-xml-to-php#29, maglnet/ComposerRequireChecker#193 (comment)
@mpdude mpdude mentioned this pull request Nov 29, 2025
Merged
mpdude added a commit to webfactory/WebfactoryHttpCacheBundle that referenced this pull request Nov 29, 2025
@mpdude
Switch from XML-based to PHP-based service configuration (#18)
f582f29 
XML-based service configuration has been deprecated since
symfony/symfony#60568 and will no longer be
supported in Symfony 8.0.

See also
https://symfony.com/blog/new-in-symfony-7-4-deprecated-xml-configuration.

In order for ComposerRequireChecker to recognise where the functions
come from, we have to import them explicitly. At the same time,
PHP-CS-Fixer must not remove the import, which is actually superfluous.

X-Ref GromNaN/symfony-config-xml-to-php#29,
maglnet/ComposerRequireChecker#193 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Functions declared in the same file are reported as unknown

1 participant

@vudaltsov