Support SQLite3 by checking for jsonb in migrations
#117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… json. This make SQLite supported
|
👋 @henrikbjorn. This is really awesome, thanks!!! |
Merged
|
a big thanks @henrikbjorn! for some reason, I had to make another PR to fix some stuff with the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fun I tried the quick start guide and ran
rpl -R 'jsonb' 'json' db/migrateand to my surprise maglev works perfectly fine with SQLite.I have added a check for
jsonbsupport in migrations. If not then fallback tojson. This is the pattern followed by Spree, Pay etc.