docker mode changes/suggestions

[satra]

@magland - i have to test this again, but when i used it in docker mode it had no memory between runs of what it had done. i.e. it didn't create a docker container and do things inside it and keep it running.

a workflow may be:

minicline docker start
minicline --docker container-name ... # it will exec things inside the container.
minicline docker stop <container-name>

also it may be useful to push a docker image of minicline. the workflow i used was similar to above, except the first and last steps were done manually myself and inside i installed minicline.

[magland]

Yeah, the way I set it up was for each command to be run in a new container. It should have memory though since it is operating on the same directory of files on the host which is mounted in the container. I think this is how it needs to be done if we don't have minicline installed in the container -- I think it's good to keep flexibility where the user can select from any container image regardless of whether it has minicline installed.

But maybe there's another way to do it.

[satra]

Yeah, the way I set it up was for each command to be run in a new container.

but it forgets installs it does inside. so it may have pip installed something and when it starts a new one, it either has to go back and install it, or in it's current mode it errors out again.

[magland]

but it forgets installs it does inside. so it may have pip installed something and when it starts a new one, it either has to go back and install it, or in it's current mode it errors out again.

Okay good point, I didn't think about installs. So I guess it should spin up a container at the beginning and then somehow the commands it wants to execute get forwarded to the running container. And then it needs to clean up on exit. Is this what you had in mind?

[satra]

yup see the workflow above.

[satra]

in fact the docker start could be provided an image name if we don't want to use a default that comes predefined and would return the container name

[magland]

yup see the workflow above.

Oh sorry, didn't see that somehow. Okay that sounds reasonable.