Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wavy-dot-pattern #62

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

tomonarifeehan
Copy link
Contributor

@tomonarifeehan tomonarifeehan commented May 24, 2024

Feature: A background dot pattern that ripples when dots are clicked.

Screen.Recording.2024-05-24.at.6.16.04.PM.mov

Copy link

vercel bot commented May 24, 2024

@tomonarifeehan is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@dillionverma
Copy link
Collaborator

very cool animation!

I have some feedback to improve it

I notice when I click on it once, and then twice, the first wave gets frozen and it looks a bit awkward.

Do you have any ideas to make that one part look less awkward?

Screen.Recording.2024-05-25.at.5.12.00.PM.mov

@tomonarifeehan
Copy link
Contributor Author

Do you have any ideas to make that one part look less awkward?

I have no ideas right now. I'll look into it.

@tomonarifeehan
Copy link
Contributor Author

tomonarifeehan commented May 27, 2024

I notice when I click on it once, and then twice, the first wave gets frozen and it looks a bit awkward.

Added setTimeout disable click for 2000ms and then allow again.

2e42305

@tomonarifeehan tomonarifeehan deleted the wavy-dot-grid branch May 27, 2024 00:11
@tomonarifeehan tomonarifeehan restored the wavy-dot-grid branch May 27, 2024 00:11
@tomonarifeehan
Copy link
Contributor Author

accidentally deleted branch lol

@dillionverma
Copy link
Collaborator

haha all good ill take a look at it again 👀

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magicui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 7:37pm

Copy link
Collaborator

@dillionverma dillionverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm for adding this 🙏

@dillionverma dillionverma merged commit 7d915af into magicuidesign:main Jun 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants