Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Prevents "Device requesting login is not supported" for Flutter SDKs #32

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Aug 11, 2023

@Ariflo Ariflo requested review from Ethella and mikeysight August 11, 2023 21:40
@Ariflo Ariflo self-assigned this Aug 11, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #84241: Integrate Webcrypto with our Flutter SDK.

@Ethella
Copy link
Member

Ethella commented Aug 11, 2023

Could you audit the source code of the library to see if they are acutally getting the kp from Secure Enclave and key store. And make sure there is no malicious code in side?

@Ariflo
Copy link
Contributor Author

Ariflo commented Aug 11, 2023

Could you audit the source code of the library to see if they are acutally getting the kp from Secure Enclave and key store. And make sure there is no malicious code in side?

@Ethella this checks out, I would compare your code for iOS to their work here. Besides they're using SecKeyCreateRandomKey I don't see much of a difference.

Same goes for your Android work as compared to theirs.

With all of this in mind, I don't see any glaring security holes here, a second pair of 👀 would make me more confident. I'll touch base with MB on this and see if he has any tricks up his sleeves to help us confirm the validity of this library.

@Ariflo Ariflo merged commit 412cc65 into main Aug 15, 2023
@Ariflo Ariflo deleted the ariflo-sc-84241-integrate-webcrypto-with-flutter-sdk branch August 15, 2023 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on login - "Device requesting login is not supported. Please try again from a secure context."
2 participants