-
Notifications
You must be signed in to change notification settings - Fork 4
chore: undelegate/finalize simplification #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
crypto-vincent
commented
Dec 20, 2024
crypto-vincent
commented
Dec 20, 2024
crypto-vincent
commented
Dec 20, 2024
crypto-vincent
commented
Dec 20, 2024
crypto-vincent
commented
Dec 20, 2024
crypto-vincent
commented
Dec 23, 2024
crypto-vincent
commented
Dec 23, 2024
GabrielePicco
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments, but LGTM overall! Thanks @crypto-vincent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to simplify and de-risk the flow of the
undelegate
andfinalize
IXs.Details
Before this PR, the
undelegate
IX effectively was a superset of thefinalize
IX.Now we expect the
finalize
IX to be called right before theundelegate
(in order for it to succeed)Additionally this PR simplifies the lamport settling code, while also clarifying the difference between the "undelegation_buffer" used only during the
undelegate
IX and the regular "buffer" used during thedelegate
IX.Greptile Summary
This PR simplifies the delegation program's state management by removing commit-related functionality and consolidating lamports handling logic.
undelegation_buffer_seeds_from_delegated_account
macro and PDA function insrc/pda.rs
for clearer buffer managementsettle_lamports_balance
function from utils intofinalize.rs
where it's primarily usedlamports.rs
utility module as part of consolidating lamports handling logic