Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing generated files from lib and .crates files off of git #54

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

crypto-vincent
Copy link
Contributor

Status Type ⚠️ Core Change Issue
Ready Tooling No --

Problem

The lib and .crates folder files in the bolt-sdk were not supposed to be git tracked

Solution

git rm -r lib and add those to .gitignore

Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work after rebasing on #53

run: |
export PATH="/home/runner/.local/share/solana/install/active_release/bin:$PATH"
cargo install --path cli --force --locked
bolt test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running bolt test after yarn build

Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@crypto-vincent crypto-vincent merged commit bf09b6e into main Jun 14, 2024
4 checks passed
@crypto-vincent crypto-vincent deleted the vbrunet/2024_06_14-remove-lib-from-git branch June 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants