Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testProject nuget packages and targetframework #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update testProject nuget packages and targetframework #122

wants to merge 2 commits into from

Conversation

eoehen
Copy link

@eoehen eoehen commented Jan 18, 2021 •
edited
Loading

Update nuget packages of the testproject:

  • Microsoft.NET.Test.Sdk from 15.5.0 to 16.8.3
  • xUnit from 2.3.1 to 2.4.1

TargetFramework from netcoreapp2.0 to netcoreapp 2.2
DotNetCliToolReference dotnet-xunit removed

@gep13
Copy link
Member

gep13 commented Jan 18, 2021

@eoehen thank you for taking the time to raise this PR. Was there a specific reason that you were looking to have these changes included?

We are currently working on the 2.1.0 release of Magic Chunks, so this change likely won't be included in that release, but we may consider it after that release is completed.

pascalberger
pascalberger requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eoehen Thanks for your contribution. There's one thing which additionally needs to be updated manually.

src/MagicChunks.Tests/MagicChunks.Tests.csproj Outdated Show resolved Hide resolved
@eoehen eoehen force-pushed the feature/Update-TestProject-Nugets branch from 9a0ebd7 to 70d3f13 Compare January 18, 2021 20:24
@eoehen
Copy link
Author

eoehen commented Jan 18, 2021

@gep13 Sorry for the misunderstanding. I ask @pascalberger first, if I can create a PR for updating this packages. You can use it for a later version.

@eoehen eoehen force-pushed the feature/Update-TestProject-Nugets branch from 70d3f13 to f4db813 Compare January 18, 2021 21:22
pascalberger
pascalberger approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pascalberger
pascalberger requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is currently failing: https://ci.appveyor.com/project/sergeyzwezdin/magic-chunks/builds/37326190

@eoehen
Copy link
Author

eoehen commented Jan 18, 2021 •
edited
Loading

@pascalberger Build is fixed.

pascalberger
pascalberger approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalberger pascalberger pascalberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eoehen @gep13 @pascalberger