Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking build #100

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Conversation

pascalberger
Copy link
Member

Currently build is failing because npm install has a warning which is written to StdErr. The npm install call is done in a PowerShell script called from the Cake build script where it's not possible to handle the error in the Cake script. I therefore have changed the Cake script to directly call npm and tfx so that we can handle the warning there.

@pascalberger pascalberger force-pushed the feature/build-update branch 2 times, most recently from f43e139 to 07e359f Compare November 25, 2020 15:38
@pascalberger pascalberger marked this pull request as ready for review November 25, 2020 17:47
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gep13 gep13 merged commit a800891 into magic-chunks:master Nov 25, 2020
@pascalberger pascalberger deleted the feature/build-update branch November 25, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants