feat: prepare ansible upgrade branch for rocky-develop - #543
feat: prepare ansible upgrade branch for rocky-develop#543MariuszJozwiak wants to merge 3 commits into
Conversation
62644bf to
fddc131
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62644bf907
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| collections: | ||
| - name: community.aws | ||
| version: 5.5.1 | ||
| - name: amazon.aws | ||
| version: 5.5.2 | ||
| - name: community.mysql | ||
| - name: ansible.utils | ||
| version: 2.10.3 | ||
| - name: community.general | ||
| version: 7.2.0 | ||
| - name: ansible.posix | ||
| version: 1.5.4 | ||
| - name: community.rabbitmq | ||
| version: 1.2.3 | ||
| - name: community.crypto | ||
| version: 2.18.0 | ||
| - name: ansible.netcommon | ||
| version: 5.1.2 | ||
| - community.crypto | ||
| - ansible.posix | ||
| - containers.podman | ||
| - name: amazon.aws | ||
| version: 11.1.0 |
There was a problem hiding this comment.
requirements-galaxy.yml drops community.aws, but this commit still leaves active calls to community.aws.* modules (for example community.aws.ec2_asg_info in site.maintenance.aws-start.yml:41, site.maintenance.aws-stop.yml:21, and site.maintenance.aws-remove-all.yml:33). On a fresh controller install from this requirements file, those tasks will fail at runtime with module resolution errors because the referenced collection is no longer installed.
Useful? React with 👍 / 👎.
| ansible.builtin.wait_for: | ||
| host: "{{ ansible_host | default(inventory_hostname) }}" | ||
| port: 22 | ||
| delay: 5 | ||
| timeout: 900 |
There was a problem hiding this comment.
This replaces an SSH-aware readiness check with a raw TCP port probe (wait_for on port 22 from localhost). wait_for does not use Ansible’s connection plugin settings (jump hosts, ProxyCommand, custom SSH ports), so environments where hosts are reachable only through Ansible SSH transport can fail this precheck even though normal task connections would work. This can cause false failures at the start of app-node provisioning.
Useful? React with 👍 / 👎.
8dc903f to
68385a5
Compare
a9e00ef to
d2be698
Compare
7117f0b to
f014c86
Compare
f014c86 to
cf81c1d
Compare
Adjust to rocky-develop
1 participant
No description provided.