Skip to content

Conversation

engcom-Foxtrot
Copy link
Contributor

Description (*)

Null should be valid value for adapter_code column in notifier_template table, as it indicates this template as generic. See

and

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to [Magento 2 instance]/admin/magento_notifier_template/databasetemplate/index/ page.
  2. Press 'New Template'
  3. Fill fields. Set 'Adapter Code' to ' - Generic -'.
  4. Save.
  5. Make sure 'Adapter Code' saved correctly.

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Foxtrot engcom-Foxtrot requested a review from naydav February 7, 2020 12:19
@ghost ghost added 2.4-develop: 3️⃣ 2.4-develop: :three: 2.4-develop: 2️⃣ 2.4-develop: :two: and removed 2.4-develop: 3️⃣ 2.4-develop: :three: 2.4-develop: 2️⃣ 2.4-develop: :two: labels Jun 10, 2020
@ghost ghost added 2.4-develop: 2️⃣ 2.4-develop: :two: 2.4-develop: 1️⃣ 2.4-develop: :one: and removed 2.4-develop: 2️⃣ 2.4-develop: :two: 2.4-develop: 1️⃣ 2.4-develop: :one: labels Jun 11, 2020
@slavvka slavvka added the 2.4-develop: exclude 2.4-develop: exclude label Jun 11, 2020
@ghost ghost removed the 2.4-develop: 1️⃣ 2.4-develop: :one: label Jun 11, 2020
@mmansoor-magento mmansoor-magento changed the base branch from 1.0-develop to develop November 17, 2020 04:15
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants