Skip to content

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented Mar 3, 2025

Description

Fixing the issue on search results landing page , Issue : setFilterOptions is not a function.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3439

Closes #PWA-3439.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 3, 2025
@pwa-studio-bot
Copy link
Collaborator

Messages
📖

Associated JIRA tickets: PWA-3439.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 196c1c0

@del15881 del15881 closed this Mar 3, 2025
@del15881 del15881 reopened this Mar 3, 2025
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 196c1c0

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 196c1c0

@glo42707
Copy link
Collaborator

glo42707 commented Mar 3, 2025

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 3, 2025

Successfully started codebuild job for pr-deploy

@glo42707
Copy link
Collaborator

glo42707 commented Mar 3, 2025

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 3, 2025

Successfully started codebuild job for scaffold-pwa

@glo42707
Copy link
Collaborator

glo42707 commented Mar 3, 2025

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 3, 2025

Successfully started codebuild job for pr-deploy

@glo42707
Copy link
Collaborator

glo42707 commented Mar 3, 2025

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 3, 2025

Successfully started codebuild job for pr-deploy

@glo82145 glo82145 merged commit 3c70775 into release/14.2.0 Mar 4, 2025
7 of 15 checks passed
glo82145 added a commit that referenced this pull request Mar 4, 2025
* Fixing the searchPage Issue : setFilterOptions is not a function. (#4430)

* Release notes/14.2.0 (#4429)

* Removed npm yml

* added release notes

* added release notes

* PWA-14.2.0- Changed log

* v14.2.0-beta.6

* Merge conflict (#4433)

* adding release 14.1.0 change.log md

* adding compatibility.js

* Removed npm yml

* v14.2.0

* v14.2.0

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

* v14.2.0-beta.7

* Release 14.2.0 v2 (#4438)

* adding release 14.1.0 change.log md

* adding compatibility.js

* v14.2.0

* v14.2.0

* merge conflict resolve

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

* resolve merge conflicts

---------

Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
glo82145 added a commit that referenced this pull request Mar 4, 2025
* Removed npm yml

* Fixing the searchPage Issue : setFilterOptions is not a function. (#4430)

* Release notes/14.2.0 (#4429)

* Removed npm yml

* added release notes

* added release notes

* PWA-14.2.0- Changed log

* v14.2.0-beta.6

* Merge conflict (#4433)

* adding release 14.1.0 change.log md

* adding compatibility.js

* Removed npm yml

* v14.2.0

* v14.2.0

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

* v14.2.0-beta.7

* Release 14.2.0 v2 (#4438)

* adding release 14.1.0 change.log md

* adding compatibility.js

* v14.2.0

* v14.2.0

* merge conflict resolve

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

---------

Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
glo82145 added a commit that referenced this pull request Mar 5, 2025
* adding release 14.1.0 change.log md

* adding compatibility.js

* v14.2.0-alpha.4

* Gomage v1 (#4393)

* Removing gomage plugin

* Removing gomage plugin

* Update package.json

* v14.2.0-alpha.5

* v14.2.0-alpha.6

* PWA remove gomage package (#4403)

* PWA remove gomage package

* PWA remove gomage package

* Feature/venia sample payments cashondelivery from latest develop (#4401)

* New Commit to Create NEW PR with Latest Develop

* Fixing Prettier Issues

* Adding workflow file to publish package

* Updating Namespace to @adobe

* Fixing Prettier Issues

* Adding module to venia-concept/package.json

* PWA Gomage

* Adding Alpha versions

* Removing Adobe Braintree Plugin from Package.json

---------

Co-authored-by: Aanchal Pawar <97873570+glo82145@users.noreply.github.com>
Co-authored-by: glo82145 <glo82145@adobe.com>

* v14.2.0-alpha.7

* v14.2.0-alpha.8

* Update package.json_for Cashon Delivery (#4405)

* Update package.json

* Update package.json

* Update package.json (#4406)

* Update package.json (#4407)

* v14.2.0-alpha.12

* Fixed unique id,aria-label and disabled attribute warnings (#4412)

Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>

* Pwa 3433::adding ontouch (#4413)

* Removing gomage plugin

* PWA-3433:: adding ontouch

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* PWA-3433::adding touch option

* v14.2.0-alpha.13

* Pwa 3437 (#4424)

* Fixed place order and filter button issue

* Fixed various console warnings in various pages

* Fixed ariaLabel errors

---------

Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>

* v14.2.0-alpha.14

* v14.2.0-beta.1

* v14.2.0-beta.2

* v14.2.0-beta.3

* Update publish-cod-to-npm.yml add release branch (#4426)

* v14.2.0-beta4

* Removed npm yml (#4428)

* v14.2.0-beta5

* v14.2.0

* v14.2.0

* Main 142 (#4440)

* Fixing the searchPage Issue : setFilterOptions is not a function. (#4430)

* Release notes/14.2.0 (#4429)

* Removed npm yml

* added release notes

* added release notes

* PWA-14.2.0- Changed log

* v14.2.0-beta.6

* Merge conflict (#4433)

* adding release 14.1.0 change.log md

* adding compatibility.js

* Removed npm yml

* v14.2.0

* v14.2.0

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

* v14.2.0-beta.7

* Release 14.2.0 v2 (#4438)

* adding release 14.1.0 change.log md

* adding compatibility.js

* v14.2.0

* v14.2.0

* merge conflict resolve

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

* resolve merge conflicts

---------

Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>

* Main 142 v1 (#4441)

* Removed npm yml

* Fixing the searchPage Issue : setFilterOptions is not a function. (#4430)

* Release notes/14.2.0 (#4429)

* Removed npm yml

* added release notes

* added release notes

* PWA-14.2.0- Changed log

* v14.2.0-beta.6

* Merge conflict (#4433)

* adding release 14.1.0 change.log md

* adding compatibility.js

* Removed npm yml

* v14.2.0

* v14.2.0

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

* v14.2.0-beta.7

* Release 14.2.0 v2 (#4438)

* adding release 14.1.0 change.log md

* adding compatibility.js

* v14.2.0

* v14.2.0

* merge conflict resolve

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>

---------

Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>

* PWA-3430::added missing libraries (#4446)

---------

Co-authored-by: arpit.khare <glo42707@adobe.com>
Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com>
Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: arpit khare <84493875+glo42707@users.noreply.github.com>
Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants