Skip to content

Deploy styleguide for PRs and master #67

Closed
@DrewML

Description

This issue is for the following packages:

[ ] venia-concept
[ ] pwa-buildpack
[X] peregrine
[ ] pwa-module
[ ] pwa-devdocs

This issue is a:

[ ] Bug
[X] Feature suggestion
[ ] Documentation issue
[ ] Other (Please Specify)

Environment

Question Answer
Magento version
Operating System + version
node.js version (node -v)
npm version (npm -v)

Description

In the old peregrine repo, we used to deploy the styleguide and link to it with any change in a PR. We're no longer doing that in the monorepo.

The problem is, we used to leverage CircleCI's artifacts feature, which had a predictable URL based on the branch/PR. This meant we could auto-link it in a PR. We can no longer do that due to a bug in CircleCI 2.0.

I'm proposing that we use Netlify's free Open Source plan to deploy to. This is what Gatsby uses to deploy and show previews in PRs.

Expected result:

Any change to Peregrine triggers a new version of the Peregrine styleguide to be deployed and linked in a PR.

Possible solutions:

Deploy to netlify in the DangerCI run.

Metadata

Assignees

Labels

enhancementNew feature or requestpkg:peregrinetoolingRelated to the developer tooling, including buildpack, webpack plugins, and debug UIs.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions