-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add middle name to checkout address html templates #8878 #8879
Conversation
@ajpevers Hi. I was checked your PR and notice next:
Could you please fix this issues ?? Thanks. |
@k7triton working on it |
Found it |
break; | ||
case 'prefix': | ||
if ($this->getCustomer()) { | ||
return $this->getCustomer()->getPrefix(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is on middle name, I would suggest to skip other fields for the sake of testing simplicity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a new PR for prefix and suffix and remove them from this PR.
fixes #8878 |
@ishakhsuvarov I've moved the prefix/suffix prefill to #9924 |
@ajpevers Thanks. We will proceed with the review shortly. |
👍 |
ACPT-1840: Failures on S3 related WebAPI test with Application Server
Description
Three checkout address templates were lacking the middle name. they are now added.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist