Combined testCodeStylePsr2() with the testCodeStyle() function. #7496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dverkade
commented
Nov 20, 2016
dverkade
commented
- Core Magento team mentioned to combine these 2 functions in the comments.
- Excluded _files/* from the PSR2 standards because these are stub files for tests and multiple classes per file throws PSR2 errors for these files.
- Core Magento team mentioned to combine these 2 functions in the comments. - Excluded _files/* from the PSR2 standards because these are stub files for tests and multiple classes per file throws PSR2 errors for these files.
…ead of the rule (which is not working according to PHP Codesniffer documentation).
|
@dverkade can you please merge with the latest mainline? |
|
This has already been fixed en merged with this commit: 0338636, so closing this PR. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 23, 2022
[Performance] MCP-946: Price Index optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.