Apply correct file permissions after renaming

[philpage1983]

Preconditions (*)

Magento version : 2.4.2 or greater

Description (*)

Determine if the new path is a file and if so apply the correct file permissions after renaming so that files don't receive execute permissions.

Manual testing scenarios (*)

1. Upload an image via edit product, edit category or pagebuilder in the admin.

Expected Result

Uploaded image should have correct file permissions e.g. umask 022 -> 0644

Actual Result

Uploaded image has incorrect file permissions e.g. umask 022 -> 0755

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Apply correct file permissions after renaming #39638: Apply correct file permissions after renaming

[m2-assistant]

Hi @philpage1983. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento create issue

[engcom-Hotel]

@magento run all tests

[igorwulff]

Can this please get some more priority? It seems a small but important change, since it affects security and file permissions and whether a file can be executable for group and others.