Skip to content

magento csp dependency issue fixed #39450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

magentoabu
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento_Paypal module has dependency on Magento_Csp module #38764

Manual testing scenarios (*)

  1. This file has a dependency on Magento_Csp: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Paypal/Model/Config.php#L9
  2. Declared it as a dependency in the module.xml

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Dec 7, 2024

Hi @magentoabu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Dec 7, 2024
@magentoabu
Copy link
Contributor Author

@magento run all tests

@magentoabu
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Jun 26, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Jun 30, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @magentoabu,

Thanks for the collaboration & contribution!

❌ QA Failed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

Disable the Magento_Csp module
Try to access the backend or frontend.

Before: ✖️ 

#63 {main} {"exception":"[object] (Error(code: 0): Cannot instantiate interface Magento\\Csp\\Model\\Collector\\MergerInterface at /usr/local/var/www/magentop/magento2/lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:50)"} []

Screenshot 2025-06-30 at 11 47 59 am

After: ✔️

Screenshot 2025-06-30 at 2 51 35 pm Screenshot 2025-06-30 at 2 52 41 pm

#63 {main} {"exception":"[object] (Error(code: 0): Cannot instantiate interface Magento\\Csp\\Model\\Collector\\MergerInterface at /usr/local/var/www/magentop/magento2/lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:50)"} []

Changes are not working as expected and could you please let us know if we are missing anything.

.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Changes Requested in Community Dashboard Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

Magento_Paypal module has dependency on Magento_Csp module
5 participants