Developer Experience: Quote AbstractItem code style (SwiftOtter's SOP-348)

[lbajsarowicz]

Description (*)

This Pull Request fixes misleading method declarations for Abstract Item methods.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Developer Experience: Quote AbstractItem code style (SwiftOtter's SOP-348) #39340: Developer Experience: Quote AbstractItem code style (SwiftOtter's SOP-348)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[lbajsarowicz]

@magento run all tests

[engcom-Hotel]

@magento create issue

[engcom-Hotel]

Hello @lbajsarowicz,

Thanks for your contribution!

Kindly resolve the conflicts on this PR, so we can proceed with the review. Meanwhile moving this PR On Hold.

Thanks

[lbajsarowicz]

@magento run all tests

[lbajsarowicz]

@engcom-Hotel Fixed.

[engcom-Hotel]

Hello @lbajsarowicz,

Thanks for the contribution!

The changes seems good to me, but please fix the static test failures.

[lbajsarowicz]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Manual testing is not required here, as this PR only updates the docblock and improves the code style. Since the builds are failing, moving it to Extended Testing.

[engcom-Dash]

@magento run Semantic Version Checker, Integration Tests, Functional Tests EE, Functional Tests B2B

[engcom-Dash]

Raised internal approval Jira for the SVC failure. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals.