-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase minimum password length for admin user #39319
base: 2.4-develop
Are you sure you want to change the base?
Increase minimum password length for admin user #39319
Conversation
Hi @torhoehn. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This line also requires modification: Line 688 in Update: There’s an additional line that needs attention in the same file: Line 694. |
031b5a3
to
7326e3e
Compare
Thanks for pointing out, I changed that file as well. I will leave this PR as simple as it is, to hopefully get it merged fast. I will create another PR one on top of it, to make the values configurable (magento/community-features#333). |
I agree that it needs to be improved for admin users, but should it also be enforced for clients? |
@sprankhub Ah sorry, I will change that as well.
@ihor-sviziev I will check that. But to keep it as simple as possible I would like to create another PR for that, because I don't know how many changes will be needed for that. |
7326e3e
to
6e26414
Compare
@magento create issue |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @torhoehn,
Thanks for the collaboration!
I think we can cover this change with an automated test, so please do the needful and also please fix the failed tests.
Thanks
Description (*)
PCI 4.0 requires a minimal password length of 12 characters, so it has to be changed from 7 to 12.
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: