Skip to content

Fix issue Redis doesn't store GraphQl schema cache #39172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

m08110071
Copy link

@m08110071 m08110071 commented Sep 16, 2024

This issue happen because GraphQl schema cache tags include item ['EAV' => 'EAV']

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes GraphQl Schema Is Not Cached With Redis #39168

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

This issue happen because GraphQl schema cache tags include item ['EAV' => 'EAV']
Copy link

m2-assistant bot commented Sep 16, 2024

Hi @m08110071. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m08110071
Copy link
Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 17, 2024
@Den4ik Den4ik self-requested a review September 18, 2024 07:08
@Den4ik Den4ik self-assigned this Sep 18, 2024
@Den4ik
Copy link
Contributor

Den4ik commented Sep 18, 2024

@magento run Unit Tests

@Den4ik
Copy link
Contributor

Den4ik commented Sep 18, 2024

@m08110071 Please sign CLA

@Den4ik
Copy link
Contributor

Den4ik commented Sep 24, 2024

@magento run Integration Tests

@idziakjakub
Copy link

@m08110071 we have the same issue after upgrade Magento from 2.4.6-p8 to 2.4.7-p3 - all GraphQl queries take more than 7 seconds to execute because of problem with save data to Redis - there is example from New Relic:

Zrzut ekranu z 2025-01-23 11-31-17
Zrzut ekranu z 2025-01-23 11-30-49

After applying your patch from here #39172, loading time dropped to about 100ms!

Zrzut ekranu z 2025-01-23 11-34-14

I think this does not happen on every instance, you need to set the L2 cache and permanent cache settings (using an external Redis server and local per app instance): https://experienceleague.adobe.com/en/docs/commerce-operations/configuration-guide/cache/level-two-cache

@Den4ik
Copy link
Contributor

Den4ik commented Jan 23, 2025

@m08110071 Could you please sign CLA, because we can't proceed with this PR without it.
@engcom-Hotel I believe that this changes could be applied by Adobe team as internal ticket if we don't have signed CLA.

@Den4ik
Copy link
Contributor

Den4ik commented Jan 23, 2025

I tested changes locally, all look good for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQl Schema Is Not Cached With Redis
4 participants