Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with incorrect data on the dashboard #39138

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

SerhiiMandrykin
Copy link

@SerhiiMandrykin SerhiiMandrykin commented Sep 3, 2024

Description (*)

This PR fixes the issue caused by dd76950
More details at #39137

Fixed Issues

  1. Fixes Issue: Incorrect Data on Magento 2 Dashboard #39137

Manual testing scenarios (*)

  1. Go to frontend.
  2. Place 2 orders.
  3. Change the creation date of the first order: -20h (in sales_order table)
  4. Go to Magento 2 Dashboard

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Sep 3, 2024

Hi @SerhiiMandrykin. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@SerhiiMandrykin
Copy link
Author

@magento run all tests

@SerhiiMandrykin
Copy link
Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor

Hi @engcom-Hotel,
Could you please share details of the issue ACP2E-1294, to which relates commit that introduced this issue?

@ihor-sviziev ihor-sviziev self-assigned this Sep 4, 2024
@ihor-sviziev ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 4, 2024
@engcom-Hotel
Copy link
Contributor

Hello @ihor-sviziev,

Below are the details of the issue fixed in ACP2E-1294:

Steps to reproduce:

  • Enable dashboard charts
  • https://docs.magento.com/user-guide/v2.3/stores/admin-dashboard.html
  • Create order and invoice it.
  • Wait until the next day. Less than 24 hours at the time of the order creation.
  • E.g.
  • Store time zone: America/Chicago
  • Order Creation time: 20:00
  • Testing time: After 00:00 (midnight)
  • Check the dashboard data
  • Note the order count
  • Change the time to the "Current month" and back

Actual result:

The statistics are wrong at the first load
Shows correct statistics after updating the time period

@ihor-sviziev
Copy link
Contributor

@SerhiiMandrykin could you please check if the listed above case is covered with your changes

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Oct 15, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Static Tests, Unit Tests

@engcom-Hotel
Copy link
Contributor

Hello @SerhiiMandrykin,

Have you had a chance to check this #39138 (comment)? It's important to know if the issue fixed in ACP2E-1294 does not reoccur due to this rollback.

Thanks

@SerhiiMandrykin
Copy link
Author

Hi @engcom-Hotel ,
sorry, i missed the comment somehow, I will check it and let you know

@engcom-Hotel
Copy link
Contributor

Hello @SerhiiMandrykin,

We are still waiting for your response here.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: Community Picked PRs upvoted by the community
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

Issue: Incorrect Data on Magento 2 Dashboard
4 participants