Fix for issue 38703 deselect default attr options

[rostilos]

Description (*)

The ability to remove the default options under Visual, Text Swatch and Dropdown attributes has been added ( a separate button under the list )

And also - for multiselect attribute ( being finalized )

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Default Product Attribute Settings Issue #38703

Manual testing scenarios (*)

1.Described in the original issue

Questions or comments

This is more as a suggested option, but I'd like to clarify implementation issues, perhaps the reviewers will suggest a better option

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rostilos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @rostilos,

Thanks for the contribution!

The code changes look good to me, but please add some automated tests in accordance with the Definition of Done (DOD).

And also please look into the build failures.

Thanks

[engcom-Hotel]

@magento run Static Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

[engcom-Hotel]

@magento run Functional Tests CE, Static Tests

[engcom-Hotel]

@magento run all tests

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

@magento give me test instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://447299878b85a0b2d92700869d12514e.instances-prod.magento-community.engineering
Admin access: https://447299878b85a0b2d92700869d12514e.instances-prod.magento-community.engineering/admin_6868
Login: 481745f3
Password: a016e86d409b

[engcom-Bravo]

Hi @rostilos,

Thanks for the collaboration & contribution!

❌ QA not Passed

For the scenario 1 we got the button and we are able to reset the default option.

When we are selecting multiple options for Multi Select type attribute it is not saving all the options only some of the options got saved.

Please refer video :

Screen.Recording.2024-08-26.at.11.33.49.mov

Could you please let us know if we are missing anything.

Thanks.

[engcom-Bravo]

Hi @rostilos,

Could you please look into this comment #38927 (comment) and please let us know if we are missing anything.

Thanks.

[rostilos]

@engcom-Bravo
Hi!
Yes, I will revise soon ( I think this bug is unrelated to edits and is reproduced on the current version and it may be more appropriate to create a separate bugfix ticket instead of a feature, but I will double-check this and let you know or make fixes ).

[engcom-Bravo]

Hi @rostilos,

Thanks for your update.

As per this comment #38927 (comment) We are moving this PR to ON HOLD till that time.

Thanks.

[engcom-Bravo]

Hi @rostilos,

Internal team has started to work on it

Thanks.

[rostilos]

@engcom-Bravo

Hi!
I have a small question regarding the process of reviewing PRs for contribution.
Our company occasionally makes contributions to the M2 repository, and I've repeatedly noticed messages under the pull-request “Internal team has started to work on it”.
This confuses me a bit, and I don't quite understand: in this case we should stop working on the PR, because the internal team is working on it, or we can continue working on it and the PR will be accepted in the future?

[engcom-Charlie]

@engcom-Bravo

Hi! I have a small question regarding the process of reviewing PRs for contribution. Our company occasionally makes contributions to the M2 repository, and I've repeatedly noticed messages under the pull-request “Internal team has started to work on it”. This confuses me a bit, and I don't quite understand: in this case we should stop working on the PR, because the internal team is working on it, or we can continue working on it and the PR will be accepted in the future?

Hi @rostilos,

Thank you for your contribution!

Sorry, if we have created any confusion for you here. The intent to say "Internal team is working on it" is that, Magento core engineering team is working on the issue which you have addressed in this PR. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR.

Thank you once again!