Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for scope bug in Catalog URL resource #38394

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

pmzandbergen
Copy link
Contributor

Description (*)

Fallback to default scope for the is_active category attribute is not working as expected on Url Resource Model. This commit adds a fallback to default scope if there is no value defined on the store scope.

Fixed Issues (if relevant)

  1. Fixes Scope bug in Catalog URL resource (_getCategories) #38393

Manual testing scenarios (*)

  1. Create 3 categories
  2. Disable one category on the default scope
  3. Disable another category on the store scope
  4. Execute \Magento\Catalog\ResourceModel\Url::getCategories(..)
  5. Validate the values of is_active on the returned data objects

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jan 29, 2024

Hi @pmzandbergen. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jan 30, 2024
@andrewbess andrewbess self-assigned this Jan 30, 2024
@andrewbess
Copy link

@magento run all tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@andrewbess
Copy link

Hello @pmzandbergen
Thank you for your contribution
But we need to check this changes history

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 8, 2024
@pmzandbergen
Copy link
Contributor Author

Any update? :)

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Nov 13, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review November 14, 2024 12:06
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Static Tests

@engcom-Hotel
Copy link
Contributor

We have created a Guild issue for this PR here:

https://github.com/magento-commerce/quality-guild/issues/82

Hence moving this PR On Hold for now. We will proceed with this as per the discussion in the guild.

Thanks

@pmzandbergen
Copy link
Contributor Author

We have created a Guild issue for this PR here:

https://github.com/magento-commerce/quality-guild/issues/82

Hence moving this PR On Hold for now. We will proceed with this as per the discussion in the guild.

Thanks

Unfortunately I don't have access to the Magento Commerce repository. I'll wait patiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: On Hold
Development

Successfully merging this pull request may close these issues.

Scope bug in Catalog URL resource (_getCategories)
4 participants