-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for scope bug in Catalog URL resource #38394
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @pmzandbergen. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
Hello @pmzandbergen |
Any update? :) |
@magento run all tests |
@magento run Functional Tests B2B, Static Tests |
We have created a Guild issue for this PR here: https://github.com/magento-commerce/quality-guild/issues/82 Hence moving this PR Thanks |
Unfortunately I don't have access to the Magento Commerce repository. I'll wait patiently. |
Description (*)
Fallback to default scope for the
is_active
category attribute is not working as expected on Url Resource Model. This commit adds a fallback to default scope if there is no value defined on the store scope.Fixed Issues (if relevant)
Manual testing scenarios (*)
\Magento\Catalog\ResourceModel\Url::getCategories(..)
is_active
on the returned data objectsContribution checklist (*)