Skip to content

Conversation

GurramSravya
Copy link

@GurramSravya GurramSravya commented Sep 11, 2023

Description (*)

  • In the version of 2.4.4 the page_size value is not set as default where it is linked to the backend configuration.
  • The version 2.4.3-p1 and 2.4.4 are compared and the page_size is now being set as default even if the page_size is not being param or any backend configuration is enabled.
  • The changes are now made in 2.4.4 version and page_size parameter is retrieved.

Related Pull Requests

#35310

Fixed Issues (if relevant)

  1. Fixes Rest API response "page_size" missing in M2.4.4 #35310

Manual testing scenarios (*)

  1. On 2.4.3-p1 create a GET request to
    rest/all/V1/orders/?searchCriteria[filterGroups][0][filters][0][field]=status&searchCriteria[filterGroups][0][filters][0][value]=processing&searchCriteria[filterGroups][0][filters][0][conditionType]=eq&searchCriteria[currentPage]=1
  2. Go to lib/internal/Magento/Framework/Webapi/ServiceInputProcessor.php and make changes in the _createFromArray function as
    if ($object instanceof SearchCriteriaInterface)
    if($object->getPageSize() === null && $this->validationConfigProvider->isInputLimitingEnabled()
    ) {
    $object->setPageSize( $this->validationConfigProvider->getDefaultPageSize());
    }
    else {
    $object->setPageSize($this->defaultPageSize);
    }
  3. The default page_size is now set, but the value will be of 999999.
  4. Now refer the app/etc/di.xml file and set the default value as 20 as given below,
    20
  5. Now create a GET request and check for the page_size value in api call.
image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 11, 2023

Hi @GurramSravya. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Sep 11, 2023
@GurramSravya
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rest API response "page_size" missing in M2.4.4
1 participant