-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where upsell and related products were controlling each oth… #37482
base: 2.4-develop
Are you sure you want to change the base?
Conversation
…ers visibility On a PDP with both upsell and related products with a limit set and a shared set of some of the products an issue could arise where products being hidden or shown by the related product js would impact the upsell products and vice versa.
Hi @igorwulff. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @igorwulff,
Thanks for the contribution!
I suggest you to cover the changes with some automated tests like functional tests.
Thanks
@magento run all tests |
…ers visibility
On a PDP with both upsell and related products with a limit set and a shared set of some of the products an issue could arise where products being hidden or shown by the related product js would impact the upsell products and vice versa.
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)