Feature/php8.1 constructor property promotion send friend

[leonhelmus]

Description (*)

Replace allmost all properties with constructor property promotion in module version: https://stitcher.io/blog/constructor-promotion-in-php-8

• Readable code
• Make Magento less complex by removing properties which take up a lot of lines.
• Imported all classes to make code more readable.
  I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @leonhelmus. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[leonhelmus]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[fredden]

Why not promote this property?

Suggested change

	SendFriend $sendfriend
	protected readonly SendFriend $_sendfriend,

[fredden]

Why not promote these properties?

Suggested change

	CustomerSession $customerSession,
	SendFriendHelper $sendfriendData,
	Registry $registry,
	CustomerViewHelper $customerViewHelper,
	protected readonly CustomerSession $_customerSession,
	protected readonly SendFriendHelper $_sendfriendData,
	protected readonly Registry $_coreRegistry,
	protected readonly CustomerViewHelper $_customerViewHelper,

[fredden]

Why not promote these properties?

Suggested change

	Registry $coreRegistry,
	FormKeyValidator $formKeyValidator,
	protected readonly Registry $_coreRegistry,
	protected readonly FormKeyValidator $_formKeyValidator,