#36748 minor refactoring handling new errores based in apiLayer #36941
Conversation
|
Hi @amarroni. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
m2-community-project
bot
added
Priority: P2
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
| }elseif (isset($response['message'])) | ||
| { | ||
| $message = $response['message']; | ||
| $this->messages[] = __($message); |
There was a problem hiding this comment.
I believe that don't make sense to translate externally received message
There was a problem hiding this comment.
Got it. I'll send exactly same message.
| }elseif (isset($response['message'])) | ||
| { |
There was a problem hiding this comment.
Please use same code style format as most of Magento code.
There was a problem hiding this comment.
Just to be on the same page. Can you reference an example on some other page??? In the meantime I'll check the style you mention.
m2-community-project
bot
added
Progress: needs update
and removed
Progress: pending review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: needs update
labels
Description (*)
Fixer.io changed there url endpoints moved to apiLayer. This commit help to handle to validate the response as the same way origin code did.
Changed errores codes to a new message response.
Related Pull Requests
Fixed Issues (if relevant)
#36748 #36010
Contribution checklist (*)