-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Issue 31043: Elastic Search interferes with the default sort order of products (changing newest first to oldest first) #36900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @rogerdz. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento give me test instance |
Hi @rogerdz. Thank you for your request. I'm working on Magento instance for you. |
Hi @rogerdz, here is your Magento Instance: https://a961f7d4071fdb23cce8cdfa12c1651a.instances.magento-community.engineering |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento give me test instance |
Hi @Viper9x. Thank you for your request. I'm working on Magento instance for you. |
Hi @Viper9x, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later. |
@magento give me test instance |
Hi @Viper9x. Thank you for your request. I'm working on Magento instance for you. |
Hi @Viper9x, here is your Magento Instance: https://a961f7d4071fdb23cce8cdfa12c1651a.instances.magento-community.engineering |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests CE , Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@rogerdz Could you please resolve conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogerdz
Could you please review my comment
['value' => 'ASC', 'label' => __('Ascending')], | ||
['value' => 'DESC', 'label' => __('Descending')], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion constant usage Select::SQL_ASC
or Collection::SORT_ORDER_ASC
is more preferable
@magento run all tests |
We have received all the required approvals on JIRA. Hence moving this PR to changes requested to address the review comments. |
@magento run all tests |
Hello @Den4ik & @engcom-Hotel, I have updated the PR with requested changes.Could you please review the changes. The failing functional Tests are not related to the changes done in this PR. Moving this PR to Pending review. Thanks |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogerdz, @engcom-Dash
Thanks for update. Changes looks good for me.
Failed Functional Tests seems are not related to changes.
Semantic Version check failed due to new element in system.xml
As the testing of this PR is already done, moving this PR to Extended Testing to further procced on this PR. |
@magento run all tests |
@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B |
The consistent failures in Functional B2B are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes ![]() ![]() Known Issues: The consistent failures in Functional CE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes ![]() ![]() Known Issues: The consistent failures in Functional EE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes ![]() ![]() Known Issues: |
Also, We have received all the required approval on the JIRA. Hence moving this PR in Merge In Progress. |
Description (*)
Add sorting condition by product id desc
Additional Information
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)