Skip to content

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Feb 21, 2023

Description (*)

Add sorting condition by product id desc

Additional Information

  • To maintain backward compatibility, We are going to introduced a store configuration for the Sort Order.
  • Path for config : Stores-> Configuration -> Catalog-> Catalog-> Storefront -> Product Listing Sort by Order

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Elastic Search interferes with the default sort order of products (changing newest first to oldest first) #31043

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2023

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Feb 21, 2023
@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 21, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 22, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 22, 2023

@magento give me test instance

@magento-deployment-service
Copy link

Hi @rogerdz. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 22, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@TuVanDev
Copy link
Member

@magento give me test instance

@magento-deployment-service
Copy link

Hi @Viper9x. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @Viper9x, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@TuVanDev
Copy link
Member

@magento give me test instance

@magento-deployment-service
Copy link

Hi @Viper9x. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@TuVanDev
Copy link
Member

I confirmed this PR resolved issue #31043. Special thanks to @rogerdz for providing the fix.

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 23, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 23, 2023

@magento run Functional Tests B2B, Functional Tests CE , Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 25, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jan 29, 2025

@rogerdz Could you please resolve conflict?

Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerdz
Could you please review my comment

Comment on lines 24 to 25
['value' => 'ASC', 'label' => __('Ascending')],
['value' => 'DESC', 'label' => __('Descending')],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion constant usage Select::SQL_ASC or Collection::SORT_ORDER_ASC is more preferable

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

We have received all the required approvals on JIRA. Hence moving this PR to changes requested to address the review comments.

@engcom-Dash engcom-Dash moved this from Pending Approval to Changes Requested in Community Dashboard Aug 21, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Hello @Den4ik & @engcom-Hotel, I have updated the PR with requested changes.Could you please review the changes. The failing functional Tests are not related to the changes done in this PR.

Moving this PR to Pending review.

Thanks

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker

Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerdz, @engcom-Dash
Thanks for update. Changes looks good for me.
Failed Functional Tests seems are not related to changes.
Semantic Version check failed due to new element in system.xml

@engcom-Dash
Copy link
Contributor

As the testing of this PR is already done, moving this PR to Extended Testing to further procced on this PR.

@engcom-Dash engcom-Dash moved this from Ready for Testing to Extended testing (optional) in Community Dashboard Aug 25, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

The consistent failures in Functional B2B are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/571e2866b5710188bd6fef735eea8f67/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/4ddc88672fb4dbae1ed2befe496c33cd/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issues:
AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest ACQE-8610
ViewportSwitcherMobileHTMLThroughBlockContentTypeTest ACQE-8608
BlockRenderHTMLThroughBlockContentTypeTest ACQE-8609
AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490

The consistent failures in Functional CE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/214b8a8e9bd9615bdc7ccb0e4b1ea2cf/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/9bf822d97550e60e56d29b8b5754583d/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issues:
StorefrontDeleteSimpleAndVirtualProductFromMiniShoppingCartTest ACQE-8560
ViewportSwitcherMobileHTMLThroughBlockContentTypeTest ACQE-8608
BlockRenderHTMLThroughBlockContentTypeTest ACQE-8609

The consistent failures in Functional EE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/b8952f3941cbfbeff483c92f05aaa68c/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/ead899ab5ba8999ce32a9bd6d6302537/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issues:
AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest ACQE-8610
ViewportSwitcherMobileHTMLThroughBlockContentTypeTest ACQE-8608
BlockRenderHTMLThroughBlockContentTypeTest ACQE-8609
AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490

@engcom-Dash
Copy link
Contributor

Also, We have received all the required approval on the JIRA. Hence moving this PR in Merge In Progress.

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending approval Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

Elastic Search interferes with the default sort order of products (changing newest first to oldest first)
7 participants