Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated subscriber spelling #36171

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Updated subscriber spelling #36171

merged 4 commits into from
Jul 4, 2024

Conversation

sandy6666
Copy link
Contributor

Updated Subscriber spelling

Fixed Issues (if relevant)

  1. Fixes typo error on a js file. #36163

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 21, 2022

Hi @sandy6666. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sandy6666
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sandy6666
Copy link
Contributor Author

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sandy6666
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Sep 22, 2022
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

3 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong
edenduong approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@edenduong edenduong added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review and removed Progress: ready for testing labels Sep 23, 2022
@engcom-Delta
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to app/code/Magento/Catalog/view/frontend/web/js/product/storage/storage-service.js
  2. Search for the word "Subsctibers"
  3. Search for the word "Subscribers"
  4. all the words with "Subsctibers" should change to "Subscribers"

Before: ✖️ 

Screenshot 2023-12-11 at 8 15 36 PM Screenshot 2023-12-11 at 8 16 03 PM

After: ✔️  

Screenshot 2023-12-11 at 8 29 53 PM Screenshot 2023-12-11 at 8 30 15 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Delta engcom-Delta self-assigned this Mar 15, 2024
@engcom-Delta
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie self-assigned this May 29, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented May 31, 2024 •
edited
Loading

The Functional B2B failures are seems to be flaky and not part of this PR. All are known failures.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36171/2cdb999054ae67a09e46bbd02fc44c7a/Functional/allure-report-b2b/index.html
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36171/2abb1103b7db303ac1092d763aedce61/Functional/allure-report-b2b/index.html#categories
image

Known issues:

  1. ACQE-6350- AdminCreateDraftQuoteFromQuoteGridPageWithMultipleStoresTest
  2. ACQE-6523- AdminReorderWithCatalogPriceRuleDiscountTest
  3. ACQE-6648- StorefrontUpdateCustomerAddressBelgiumTestCest

@engcom-Charlie
Copy link
Contributor

The Functional EE failures seems to be flaky and having known issues.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36171/7c46c470c41b57fa4fa4433dd8925042/Functional/allure-report-ee/index.html#categories/2afd3b34d66263d23832312f8fed37f1/fa65c3178c3dd199/
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36171/d017d08824933752be29edb9ba03b5c9/Functional/allure-report-ee/index.html#categories
image

  1. ACQE-6331- StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTestCest
  2. ACQE-6523- AdminReorderWithCatalogPriceRuleDiscountTest

@engcom-Charlie
Copy link
Contributor

The WebAPI test failures seems to be flaky and having known issues. Hence moving the PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36171/fa7a68e0bceb06d13aaf72db0ea705a4/WebApi/console-error-logs.html
image

image image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36171/bc6cbb144010137fffb548450cc15b2b/WebApi/console-error-logs.html
image

Known issue:

  1. ACP2E-3085- testSetBillingAddressIfCustomerIsNotOwnerOfAddress

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 3b91757 into magento:2.4-develop Jul 4, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenduong edenduong edenduong approved these changes

Assignees

@edenduong edenduong

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P3 May be fixed according to the position in the backlog. Progress: accept
Projects
Pull Requests Dashboard
Status: Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo error on a js file.
6 participants
@sandy6666 @engcom-Delta @engcom-Charlie @edenduong @sdzhepa @magento-devops-reposync-svc