Skip to content

Issue/33352 #35700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

Issue/33352 #35700

wants to merge 3 commits into from

Conversation

artskirk
Copy link

@artskirk artskirk commented Jun 29, 2022

Description (*)

Based on this issue I have provided an additional configuration to enable/disable tax rounding when catalog price includes tax.

Manual testing scenarios (*)

  • Login to Magento Admin
  • Add New Tax Rate - 19% in Stores/Tax Zones and Rates

tax-1

  • Apply created tax rate in Stores/Tax Rules
    tax-2

  • Set every configuration in Sales / Tax to Excluding Tax (Calucation Settings: Catalog Prices, Shipping PRices, Apply Discount on Prices, All Display Settings)

  • Set "The Tax Calculation Method Based On" to "Unit Price"

  • Disable "Apply Tax Rounding" setting in Sales/Tax/Calculation Settings

  • Add products in high quantities to the shopping cart, e.g., 200

  • Place Order

  • Observe Tax Amount

tax-3

Expected Result
Tax Amount should not be rounded

Fixes #33352

@m2-assistant
Copy link

m2-assistant bot commented Jun 29, 2022

Hi @artskirk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jun 29, 2022
@artskirk
Copy link
Author

artskirk commented Aug 2, 2022

@magento run Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tax calculation rounded and wrong with All set to exclusive Tax + tax per product + several products
1 participant