Fixed Ui Export Search Result Iterator for zero keys #3546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed Ui Export Search Result Iterator for zero keys
NadiyaS
added
the
Issue: Ready for Work
|
Hi @sivaschenko, |
|
Thank you @NadiyaS ! |
|
Was fixed in mainline. Not actual anymore |
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 18, 2018
[2.3-develop] Bug Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grid collections with id starting from zero are not exported to xml, because first iteration valid check (bool)$this->key() will return false (as key is 0).
From key() php function documentation: If the internal pointer points beyond the end of the elements list or the array is empty, key returns null.
So check for is_null is most appropriate here.