Fixed issue where dynamic JS price updates for tier prices wouldn't u…

[LeanderFS]

…pdate when catalog price display was set to either Excluding or Including/Excluding tax

Description (*)

This PR fixes an issue regarding the dynamic price updates on the product detail pages. When the store is set to display prices excluding or including/excluding tax changing the quantity doesn't update the prices correctly. This fix makes sure all displayed prices are updated regardless of the tax display settings.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Old price excluding TAX is incorrectly replaced by JavaScript #11998

Manual testing scenarios (*)

1. Under Configuration > Sales > Tax > Price Display Settings set Display Product Prices In Catalog to either Including tax or Including and Excluding Tax.
2. Create a new product with a tier price
3. On the product detail page, change the quantity to match a tier price tier.

When step 1 is set to Excluding Tax, the price should update to show the tier price excluding tax.
When step 1 is set to Including and Excluding Tax, both prices should update to show the correct values
When step 1 is set to Including Tax, the price should update to show the tier price including tax.

--

Questions or comments

Contribution checklist (*)

• [ x ] Pull request has a meaningful description of its purpose
• [ x ] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @LeanderFS. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[LeanderFS]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[sdzhepa]

@LeanderFS

Related issue was marked as Cannot Reproduce #11998 (comment)

Unfortunately, we cannot process and deliver PR if we do not have clear, reproducible steps on the latest code-base

cc: @engcom-Lima