Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unit tests to be compatible with php8 [part 1] #34045

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix Unit tests to be compatible with php8 [part 1] #34045

merged 1 commit into from
Sep 29, 2021

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Sep 10, 2021 •
edited by andrewbess
Loading

Description (*)

Fixes existing Unit Tests (and related files from Magento Core) to be compatible both with PHP7 and PHP8.

Related Pull Requests

Related Issues (*)

  1. Stabilize Unit tests #34019

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2021

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 10, 2021
@karyna-t
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess andrewbess force-pushed the php8-compatibility/fix-unit-tests-to-be-comptaible-with-php8 branch from 5d32f99 to 2f4cfce Compare September 12, 2021 15:05
@eduard13 eduard13 self-assigned this Sep 14, 2021
@andrewbess
Copy link

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link

@magento run all tests with extensions magento-commerce/security-package-b2b:platform-health

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run Unit Tests, Integration Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run Unit Tests, Static Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8-compatibility/fix-unit-tests-to-be-comptaible-with-php8 branch from deb3385 to 562b98d Compare September 27, 2021 12:32
@karyna-t
Copy link
Contributor Author

@magento run Unit Tests, Static Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8-compatibility/fix-unit-tests-to-be-comptaible-with-php8 branch from 562b98d to fcf51a8 Compare September 27, 2021 16:02
@karyna-t
Copy link
Contributor Author

@magento run all tests

@karyna-t
Copy link
Contributor Author

@magento run all tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8-compatibility/fix-unit-tests-to-be-comptaible-with-php8 branch from 4e42990 to baca328 Compare September 29, 2021 12:11
@karyna-t
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev removed their assignment Sep 29, 2021
@karyna-t karyna-t force-pushed the php8-compatibility/fix-unit-tests-to-be-comptaible-with-php8 branch from 59892fa to 4789a2e Compare September 29, 2021 13:59
@andrewbess
Copy link

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link

@magento run all tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 9a72a4f into magento:platform-health Sep 29, 2021
@m2-assistant
Copy link

m2-assistant bot commented Sep 29, 2021

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-t karyna-t deleted the php8-compatibility/fix-unit-tests-to-be-comptaible-with-php8 branch November 26, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

@andrewbess andrewbess andrewbess approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@xmav xmav

@andrewbess andrewbess

@eduard13 eduard13

Labels
Award: category of expertise Award: special achievement Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@karyna-t @andrewbess @xmav @Den4ik @ihor-sviziev @eduard13 @magento-engcom-team @magento-devops-reposync-svc