Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST SYNCING PR [DO NOT TOUCH] #33746

Closed
wants to merge 40 commits into from
Closed

TEST SYNCING PR [DO NOT TOUCH] #33746

wants to merge 40 commits into from

Conversation

andrewbess
Copy link
Contributor

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/582

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

tufahu and others added 30 commits June 25, 2021 13:35
@tufahu
cast incoming untyped parameters to string type
64e6731
@tufahu
add unit tests for encodeUrlParam and escapeCss methods
94e140f
@tufahu
move type cast from Escaper to RouteParamsResolver and add type hints
a8c323c
@karyna-t
Remove usage of laminas\mvc from Setup Wizard page
6d4b966
@tufahu @ihor-sviziev
Apply suggestions from code review
9f2af73 
Remove return types due to backward compatibility

Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@AntonEvers
Fixes #33430
e1a9833
@AntonEvers
accidentally removed .htaccess
e01e67c
@andrewbess
CE-32868: Updated monolog to version 2.3.1
cd42926
@andrewbess
CE-32868: Fixed the codebase to take a compatibility
8e6aedc
@andrewbess
CE-32868: Fixed tests
95843d3
@andrewbess
Merge branch 'platform-health' of https://github.com/karyna-tsymbal-a…
fc3de94 
…twix/magento2 into improvement/m2-33338-remove-laminas-mvc-dependency-from-setup-wizard-page
@andrewbess
Merge branch 'platform-health' of https://github.com/karyna-tsymbal-a…
863efc8 
…twix/magento2 into improvement/m2-33338-remove-laminas-mvc-dependency-from-setup-wizard-page
@andrewbess
CE-33338: Removed unneeded php code sniffer disabling
2fc17c1
@andrewbess
Merge branch 'platform-health' of https://github.com/andrewbess/magento2
0f68419 
 into improvement/CE-32868-update-monolog-to-latest-version

� Conflicts:
�	composer.json
�	composer.lock
@AntonEvers
Merge branch 'platform-health' into phpmd
e62a2fe
@anzin
32853: Upgraded legacy-build.min.js to the latest version
0bbe7e5
@andrewbess
Merge pull request #33432 from AntonEvers/phpmd
a8c0e9b 
Resolve warnings in PHPMD execution Fixes #33430
@andrewbess
Merge pull request #33397 from karyna-tsymbal-atwix/improvement/m2-33…
2136092 
…338-remove-laminas-mvc-dependency-from-setup-wizard-page

33338: Remove usage of laminas\mvc from Setup Wizard page
@andrewbess
CE-32868: Rebuilt composer.lock after releasing MFTF
4eca2e2
@andrewbess
Merge pull request #33497 from andrewbess/improvement/CE-32868-update…
b2a9e91 
…-monolog-to-latest-version

Updated monolog/monolog to 2.3.1
@andrewbess
Merge branch 'platform-health' of https://github.com/anzin/magento2 i…
99cba7f 
…nto improvement/m2-32853-upgrade-legacy-build-min-to-latest-version
@andrewbess
Merge pull request #33587 from anzin/improvement/m2-32853-upgrade-leg…
356a4c9 
…acy-build-min-to-latest-version

32853: Upgraded legacy-build.min.js to the latest version
@andrewbess
CE-33574: The laminas/laminas-escaper composer dependency has been …
e44a8b0 
…updated
@karyna-t
Update php-cs-fixer to 3.0.0
a330a1a
@ihor-sviziev
Fix incompatibility with laminas-escaper (2.7.1)
733dec5 
Apply suggestions from code review
@karyna-t
update symfony/console (php-cs-fixer dependency) to 4.4.29 to avoid a…
2758775 
… critical issue in compilation
@karyna-t
update gitignore with new file names for php-cs-fixer
78ed483
@andrewbess
Merge pull request #33353 from tufahu/fix-laminas-escaper-type
057e838 
Incompatibility with laminas-escaper (>=2.7.1) has been fixed
@andrewbess
Merge branch 'platform-health' of https://github.com/andrewbess/magento2
d73a8d9 
 into CE-33574-update-laminas-escaper-composer-dependency
@andrewbess
Merge pull request #33624 from andrewbess/CE-33574-update-laminas-esc…
1e281a2 
…aper-composer-dependency

The `laminas/laminas-escaper` composer dependency has been updated
andrewbess and others added 10 commits July 31, 2021 07:42
@andrewbess
Merge pull request #33627 from karyna-tsymbal-atwix/improvement/m2-33…
3dd4f41 
…507-update-php-cs-fixer-3.0.0

`friendsofphp/php-cs-fixer` composer dependency has been updated
@andrewbess
CE-33580: The Web Setup landing page has been covered with MFTF tests
ae23ad7
@andrewbess
Merge pull request #33653 from andrewbess/CE-33580-cover-web-setup-pa…
2d291ad 
…ge-with-mftf

The Web Setup landing page has been covered with MFTF tests
@andrewbess
CE-33672: RequireJS has been upgraded to the latest version (2.3.6)
b500a6a
@andrewbess
Merge pull request #33570 from mrtuvn/update-latest-requirejs
5812ec7 
RequireJs has been updated to the latest version
@sivaschenko
Merge branch '2.4-develop' of github.com:magento-commerce/magento2ce …
62e258a 
…into platform-health
@mrtuvn @andrewbess
CE-32845: Update lessjs to v3.13.1
16c2b1b
@sivaschenko
Fixed unit tests
6636b73
@sivaschenko
Merge pull request #31618 from mrtuvn/update-lessjs-v3
d0120fd 
Update lessjs to v3.13.1
@sivaschenko
Merge branch '2.4-develop' of github.com:magento-commerce/magento2ce …
feae904 
…into platform-health
@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2021

Hi @andrewbess. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@andrewbess
Copy link
Contributor Author

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess andrewbess closed this Aug 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2021

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Lib/Frontend Component: Backend Component: Composer Component: Developer Component: Escaper Component: Logger Component: Newsletter Component: Test Component: Ui Component: Url Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@andrewbess @novikor @magento-engcom-team @tufahu @karyna-t @AntonEvers @anzin @ihor-sviziev @sivaschenko @mrtuvn