Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32460 GraphQL: add category_url_path to ProductAttributeFilterInput #33090

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

khrystynastolbova
Copy link
Contributor

@khrystynastolbova khrystynastolbova commented May 27, 2021

Description (*)

This pull request adds category_url_path to ProductAttributeFilterInput

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes GraphQL: add category_url_path to ProductAttributeFilterInput #32460

Manual testing scenarios (*)

{
  products(filter:{
    category_url_path : {eq:"category-1/category-1-2"}
  }) {
    total_count
    items {
      name
      sku
    }
  }
}

Screenshot 2021-05-27 at 16 11 10

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2021

Hi @khrystynastolbova. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: CatalogGraphQl Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 27, 2021
@khrystynastolbova
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label May 27, 2021
@khrystynastolbova
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@khrystynastolbova
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@khrystynastolbova
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@paales
Copy link
Contributor

paales commented Aug 16, 2022

@cpartica @khrystynastolbova Any reason why this is blocked? We currently have to do an additional roundtrip to get this working.

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Lima
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Lima
Copy link
Contributor

@magento give me test instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Copy link
Contributor

@engcom-Lima engcom-Lima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khrystynastolbova ,

Thanks for the collaboration & contribution!

❌ QA not Passed

Products in the child categories are not displaying in the response.

Manual Scenario Steps

  1. Create subcategory under default. (say A)
  2. Create 2 subcategories under A(Child). For ex- A ->B,A-> C
  3. Add products to each subcategories.
  4. Execute below graphQL query:
{
  products(filter:{
    category_url_path : {eq:"Clothing"}
  }) {
    total_count
    items {
      name
      sku
    }
  }
}

✔️ Expected result After Fix Product should be displayed of sub subcategory(child category)

❌ Actual result After Fix Products were not getting displayed from child category. Getting error as "message": "No category with the provided category_url_path was found",
Screenshot 2023-04-12 at 4 23 24 PM
Video for your reference: https://shared-assets.adobe.com/link/66c20a5d-2db7-4d44-7627-1c83ed423e38

@paales
Copy link
Contributor

paales commented Apr 12, 2023

@engcom-Lima the result of your query is to be expected. The query you meant to do was Clothing/Test1 and Clothing/Sports, right?

@engcom-Lima
Copy link
Contributor

@magento give me test instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:
Run below graphQL query:

{
  products(filter:{
    category_url_path : {eq:"category-1/category-1-2"}
  }) {
    total_count
    items {
      name
      sku
    }
  }
}

Before: ✖️
Screenshot 2023-04-12 at 3 21 08 PM

After: ✔️
Screenshot 2023-04-12 at 3 23 45 PM
image

Referring to the comment #33090 (comment) .Moving to Merge in Progress.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogGraphQl Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: done Project: Community Picked PRs upvoted by the community Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL: add category_url_path to ProductAttributeFilterInput