-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32460 GraphQL: add category_url_path to ProductAttributeFilterInput #33090
base: 2.4-develop
Are you sure you want to change the base?
32460 GraphQL: add category_url_path to ProductAttributeFilterInput #33090
Conversation
Hi @khrystynastolbova. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@cpartica @khrystynastolbova Any reason why this is blocked? We currently have to do an additional roundtrip to get this working. |
@magento run all tests |
@magento give me 2.4-develop instance |
Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Lima, here is your Magento Instance: https://36499e1cbb51bbc382ac9f50e30a4da6.instances-prod.magento-community.engineering |
@magento give me test instance |
Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Lima, here is your Magento Instance: https://1fd06138593dd814821d59fd314ed230.instances-prod.magento-community.engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @khrystynastolbova ,
Thanks for the collaboration & contribution!
❌ QA not Passed
Products in the child categories are not displaying in the response.
Manual Scenario Steps
- Create subcategory under default. (say A)
- Create 2 subcategories under A(Child). For ex- A ->B,A-> C
- Add products to each subcategories.
- Execute below graphQL query:
{
products(filter:{
category_url_path : {eq:"Clothing"}
}) {
total_count
items {
name
sku
}
}
}
✔️ Expected result After Fix Product should be displayed of sub subcategory(child category)
❌ Actual result After Fix Products were not getting displayed from child category. Getting error as "message": "No category with the provided category_url_path
was found",
Video for your reference: https://shared-assets.adobe.com/link/66c20a5d-2db7-4d44-7627-1c83ed423e38
@engcom-Lima the result of your query is to be expected. The query you meant to do was |
@magento give me test instance |
Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Lima, here is your Magento Instance: https://1fd06138593dd814821d59fd314ed230.instances-prod.magento-community.engineering |
✔️ QA Passed Preconditions:
Manual testing scenario:
Referring to the comment #33090 (comment) .Moving to Merge in Progress. |
…_catalog_url_path
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Description (*)
This pull request adds category_url_path to ProductAttributeFilterInput
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)