[32058][To 2.4-develop] Marked classes and interfaces as API part 3

[Usik2203]

Description (*)

This PR fixes #32058

Related Pull Requests

#32185

Fixed Issues (if relevant)

1. Fixes Mark classes and interfaces as API part 3 #32058>

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Usik2203]

@magento run all tests

[danielrussob]

@magento run Functional Tests EE

[danielrussob]

@magento run Unit Tests

[danielrussob]

I confirm that this PR is just a code cleanup / marked as API some class. We are waiting for tests.

[danielrussob]

I confirm that all files mentioned in issue (#32058) are covered

[Usik2203]

Hi @aleron75 @danielrussob
Thank you for review .
I have only one doubts about label Cleanup
I am not sure that PRs which related with API Changes project should have Cleanup label.
I do this conclusion due to

1. API Changes issues have P1 priority
2. We already have examples where such type PRs were merged and were not considered as Cleanup .

@sivaschenko @gabrieldagama Could i kindly ask you to clarify should such type of PRs have Cleanup label or should be understood as an improvement ?

Thanks !

[aleron75]

Good point @Usik2203, let's see what others say. Thank you

[sivaschenko]

I would agree with @Usik2203 .

Cleanup PRs are usually PRs that have little to no impact on functionality and developer experience. API Changes PRs do introduce a big change of developer experience, so I wouldn't mark them as a cleanup.

[danielrussob]

Unit tests are fake positive @sivaschenko can you confirm, please?

[danielrussob]

This failing test is fake positive

[gabrieldagama]

@magento run Unit Tests

[gabrieldagama]

@magento import code to https://github.com/magento-engcom/magento2ce

[magento-engcom-team]

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32735.

[m2-assistant]

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.