-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecessary spacing on backend grid #32622
base: 2.4-develop
Are you sure you want to change the base?
Removed unnecessary spacing on backend grid #32622
Conversation
Hi @Bartlomiejsz. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run Functional Tests EE |
Hi @ihor-sviziev, thank you for the review. |
@magento create issue |
@magento run all tests |
@magento run all tests |
@magento run WebAPI Tests,Integration Tests,Functional Tests EE,Functional Tests CE,Functional Tests B2B |
Functional Tests B2B,Functional Tests CE,Functional Tests EE failure are different on last two run on same commit. Also they contain known failures. Integration Tests and WebAPI Tests contain known failure Hence moving it to |
Description (*)
This PR fixes minor issue on backend grid. When there are selected items, there is unnecessary spacing being displayed.
Main change is line 68 - rest is only refactoring.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
To reproduce this issue, HTML minification probably must be disabled.
I don't think any tests are applicable here.
Contribution checklist (*)
Resolved issues: