Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary spacing on backend grid #32622

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Mar 29, 2021

Description (*)

This PR fixes minor issue on backend grid. When there are selected items, there is unnecessary spacing being displayed.
Main change is line 68 - rest is only refactoring.
image

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. In Backend, go to System -> Tools -> Cache Management
  2. Select few rows on grid
  3. Make sure there is no spacing in (X selected) phrase
    image

Questions or comments

To reproduce this issue, HTML minification probably must be disabled.
I don't think any tests are applicable here.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Removed unnecessary spacing on backend grid #38502: Removed unnecessary spacing on backend grid

@m2-assistant
Copy link

m2-assistant bot commented Mar 29, 2021

Hi @Bartlomiejsz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Bartlomiejsz
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Mar 30, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8977 has been created to process this Pull Request

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 8, 2021
@engcom-Delta
Copy link
Contributor

@magento create issue

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

1.In Backend, go to System -> Tools -> Cache Management
2.Select few rows on grid
3.Make sure there is no spacing in (X selected) phrase

Before: ✖️ 

Screenshot 2024-03-15 at 7 59 23 PM Screenshot 2024-03-15 at 7 48 19 PM Screenshot 2024-03-15 at 7 48 32 PM

After: ✔️  

Screenshot 2024-03-15 at 7 59 23 PM Screenshot 2024-03-15 at 7 56 34 PM Screenshot 2024-03-15 at 7 56 48 PM Screenshot 2024-03-15 at 7 58 54 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run WebAPI Tests,Integration Tests,Functional Tests EE,Functional Tests CE,Functional Tests B2B

@engcom-Echo
Copy link
Contributor

Functional Tests B2B,Functional Tests CE,Functional Tests EE failure are different on last two run on same commit. Also they contain known failures.
List of known failures.
ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest
ACQE-6487 - StorefrontSelectedByQueryParamsConfigurableOptionsThumbImagesTest
ACQE-6590 - AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest
ACQE-6423 - ApplyTaxesAndFptForSimpleProductWithCanadianPstOriginTest
ACQE-5677 - StorefrontQuoteCanBeRenamedUntilLockedTest

Functional Tests B2B
Run1
Screenshot 2024-05-30 at 1 40 57 PM

Run2
Screenshot 2024-05-30 at 1 42 57 PM

Functional Tests EE
Run1
Screenshot 2024-05-30 at 1 41 10 PM
Run2
Screenshot 2024-05-30 at 1 43 06 PM

Functional Tests CE
Run1
Screenshot 2024-05-30 at 1 41 03 PM

Run2
Screenshot 2024-05-30 at 1 43 02 PM

Integration Tests and WebAPI Tests contain known failure
Screenshot 2024-05-30 at 1 47 08 PM

Screenshot 2024-05-30 at 1 47 27 PM

Hence moving it to merge in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Backend Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Removed unnecessary spacing on backend grid
6 participants