Catch throwable errors during model save (rollback)

[Sekiphp]

Description (*)

When you throw Error class (or some inherited class) in beforeSave method - Magento do not rollback started transaction correctly.

You can look at similar pull request for OpenMage project: OpenMage/magento-lts#1483

Exception implements Throwable - so this change should be unbreakable

Manual testing scenarios (*)

1. throw new Error('error from some specifiec reason');

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Catch throwable errors during model save (rollback) #32562: Catch throwable errors during model save (rollback)

[m2-assistant]

Hi @Sekiphp. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Sekiphp]

@magento run all tests

[swnsma]

@magento create issue

[swnsma]

Hi @Sekiphp!
Thank you for your contribution!
According to our Definition of Done, all new changes should be covered with corresponding auto-tests.
May I ask you to add unit-tests coverage for this specific case?

[Sekiphp]

@swnsma I tried to add unit test, but I usually using another testing framework and I had problem to make this test working. Can you please give me some suggestion what to edit/fix in this tests? Thank you!

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ishakhsuvarov]

Hi

I am closing this PR for now as it seems like it has become stale and still needs work.

Please feel free to reopen if you wish to continue.

Thanks!

[Sekiphp]

@ishakhsuvarov Can you please reopen this pull request? Automated tests are already written....