Allow translations for Login as Customer button

[jbrada]

Description (*)

The Login As Customer module adds a button to the customer edit page in the Admin panel.

The text "Login as Customer" can not be translated even though it is defined as "translatable" in the module's di.xml. Therefore it does not display well in other language versions.

This pull request fixes this behaviour and makes translation of the button possible.

Manual testing scenarios (*)

1. Switch admin's user account to a different language (e.g. cs_CZ)
2. Add translation to the Login as Customer string.
3. The button is translated

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Allow translations for Login as Customer button #32972: Allow translations for Login as Customer button

[m2-assistant]

Hi @jbrada. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

Imho i think you can add new csv file translate to this module (folder i18n)
Possible coverage change with automatic tests

[aleron75]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento create issue

[Den4ik]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

✔️ Approved

[engcom-Charlie]

✔️ QA Passed

Preconditions:

1. Magento 2.4

Manual testing scenario:

1. Set Admin user account to France from Interface Locale
2. Added fr_FR.csv file in customer module with translated text for Login as Customer string
3. Go to Customer edit page

Actual Result: ✔️

1. Login as Customer button is translated.

After: ✔️

Before: ✖️

Tested all the manual scenarios, no impact on regression testing.

[sidolov]

Please, cover changes with automated tests

[sidolov]

Please, add an explicit visibility modifier. Const should be private

[engcom-Charlie]

Hi @jbrada

Thank you for your contribution.

I will check the review comments and do the needful.

Thank you!

[engcom-Charlie]

Hi @jbrada, @Den4ik

Thank you for your contribution.

@sidolov, I have worked on the review comments.

Added appropriate visibility modifier and created new MFTF test case for automation.

Requesting for the review again so moving it to the Pending Review.

Thank you!

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.