fix arbitrary php code execution #3233 #3235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i hope this is what this function was intended to do
perhaps no change should be done in this function? Option is to remove this function at all, but i don't if something is not depended on it..
Contributor
|
@scholtz thanks for your contribution, but the current implementation serves a purpose. It adds slashes to unescaped quotes and resolves concatenation operators. These may be present because this method is used for extracting phrases from PHP code in order to construct translation files. We would like to stop using eval at some point, but the solution must preserve functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i hope this is what this function was intended to do