Update Framework interfaces and mark as API #32142

mrtuvn · 2021-02-12T14:29:26Z

Description (*)

Mark following interfaces as API + removed deprecated methods usage in code base + added declare strict_types
Update integration tests coverage with changes

lib/internal/Magento/Framework/App/Config/ValueInterface.php @api
lib/internal/Magento/Framework/MessageQueue/ConsumerConfigurationInterface.php @api + remove deprecated method
lib/internal/Magento/Framework/View/DesignInterface.php mark @api + remove deprecated method setArea from interface
lib/internal/Magento/Framework/Webapi/CustomAttributeTypeLocatorInterface.php @api + remove deprecated method

Related Pull Requests

Fixed Issues (if relevant)

Fixes Update Framework interfaces #32037

Manual testing scenarios (*)

...
...

Questions or comments

CC: @ihor-sviziev @sivaschenko @kandy @pauliarush

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-02-12T14:29:28Z

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-02-12T14:59:52Z

app/code/Magento/Theme/Model/View/Design.php

@@ -105,6 +105,7 @@ public function __construct(
     *
     * @param string $area
     * @return $this
+     * @deprecated
     */
    public function setArea($area)
    {


@sivaschenko @sidolov @gabrieldagama should we safe for remove this method ? Method defined in interface already removed but i just think we should keep method here for backward compatible

In my opinion we should clear legacy code in major release

app/code/Magento/Eav/Model/TypeLocator/SimpleType.php

ihor-sviziev · 2021-02-17T08:06:04Z

@magento run all tests

mrtuvn · 2021-02-17T10:20:18Z

@magento run Integration Tests, Static Tests, Unit Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE

app/code/Magento/Theme/Model/View/Design.php

mrtuvn · 2022-07-31T06:43:25Z

@magento run all tests

magento-automated-testing · 2022-07-31T06:43:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2022-08-06T02:00:40Z

@magento run all tests

magento-automated-testing · 2022-08-06T02:00:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2022-08-31T11:21:27Z

@magento run all tests

magento-automated-testing · 2022-08-31T11:21:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2022-09-18T02:23:08Z

@magento run all tests

magento-automated-testing · 2022-09-18T02:23:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 12, 2021

m2-community-project bot added the Progress: pending review label Feb 12, 2021

mrtuvn commented Feb 12, 2021

View reviewed changes

mrtuvn force-pushed the api-interfaces-mark-issue-32037 branch 2 times, most recently from 172f8a0 to ebaed95 Compare February 14, 2021 10:05

mrtuvn commented Feb 14, 2021

View reviewed changes

app/code/Magento/Eav/Model/TypeLocator/SimpleType.php Show resolved Hide resolved

m2-community-project bot assigned sivaschenko Feb 15, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Feb 15, 2021

mrtuvn force-pushed the api-interfaces-mark-issue-32037 branch from ebaed95 to 554149f Compare February 16, 2021 03:32

gabrieldagama added this to the 2.5 milestone Feb 16, 2021

ihor-sviziev self-assigned this Feb 17, 2021

mrtuvn force-pushed the api-interfaces-mark-issue-32037 branch from 554149f to 1858976 Compare February 17, 2021 10:18

mrtuvn requested a review from sivaschenko February 17, 2021 10:21

ihor-sviziev requested changes Feb 17, 2021

View reviewed changes

app/code/Magento/Theme/Model/View/Design.php Show resolved Hide resolved

m2-community-project bot added Progress: needs update and removed Progress: review labels Feb 17, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Feb 17, 2021

Rework method getData area

cf423f3

mrtuvn force-pushed the api-interfaces-mark-issue-32037 branch from de18fa6 to cf423f3 Compare July 31, 2022 06:42

Nuranto mentioned this pull request Aug 1, 2022

Theme issue on setup:upgrade #35843

Closed

5 tasks

magento deleted a comment from tuna2smc Aug 2, 2022

mrtuvn added 4 commits August 3, 2022 21:42

Update Area.php

d0554ed

Update Theme.php

4f10f8b

Update visibility const

225b553

Merge branch '2.4-develop' into api-interfaces-mark-issue-32037

879d479

mrtuvn requested review from ihor-sviziev and Den4ik August 5, 2022 13:42

Merge branch '2.4-develop' into api-interfaces-mark-issue-32037

cce9d21

ihor-sviziev removed their request for review August 9, 2022 12:19

Merge branch '2.4-develop' into api-interfaces-mark-issue-32037

74887c5

mrtuvn added 2 commits September 18, 2022 09:20

Update code

100e313

Merge branch '2.4-develop' into api-interfaces-mark-issue-32037

194c3e3

mrtuvn marked this pull request as draft March 20, 2023 14:25

mrtuvn marked this pull request as ready for review December 22, 2023 03:37

mrtuvn closed this Dec 22, 2023

m2-community-project bot removed the Progress: review label Dec 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Framework interfaces and mark as API #32142

Update Framework interfaces and mark as API #32142

mrtuvn commented Feb 12, 2021 •

edited

Loading

m2-assistant bot commented Feb 12, 2021

mrtuvn Feb 12, 2021

Den4ik May 19, 2021 •

edited

Loading

ihor-sviziev commented Feb 17, 2021

mrtuvn commented Feb 17, 2021

mrtuvn commented Jul 31, 2022

magento-automated-testing bot commented Jul 31, 2022

mrtuvn commented Aug 6, 2022

magento-automated-testing bot commented Aug 6, 2022

mrtuvn commented Aug 31, 2022

magento-automated-testing bot commented Aug 31, 2022

mrtuvn commented Sep 18, 2022

magento-automated-testing bot commented Sep 18, 2022

Update Framework interfaces and mark as API #32142

Update Framework interfaces and mark as API #32142

Conversation

mrtuvn commented Feb 12, 2021 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Feb 12, 2021

mrtuvn Feb 12, 2021

Choose a reason for hiding this comment

Den4ik May 19, 2021 • edited Loading

Choose a reason for hiding this comment

ihor-sviziev commented Feb 17, 2021

mrtuvn commented Feb 17, 2021

mrtuvn commented Jul 31, 2022

magento-automated-testing bot commented Jul 31, 2022

mrtuvn commented Aug 6, 2022

magento-automated-testing bot commented Aug 6, 2022

mrtuvn commented Aug 31, 2022

magento-automated-testing bot commented Aug 31, 2022

mrtuvn commented Sep 18, 2022

magento-automated-testing bot commented Sep 18, 2022

mrtuvn commented Feb 12, 2021 •

edited

Loading

Den4ik May 19, 2021 •

edited

Loading