Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE 30481 - Detach google adwords from google analytics #31885

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

zaximus84
Copy link

Description (*)

Google Adwords configuration is dependent on Google Analytics config and ACL, but there is no declared dependency in composer.json (and adwords doesn't seem to rely on any other analytics code). This PR moves adwords to its own section and ACL so it's still configurable when analytics is removed.

The old config path is explicitly defined for all fields in the PR changes so that existing configuration on a Magento installation will still apply after the config fields are moved.

Fixed Issues (if relevant)

  1. Fixes Google Adwords menu items are not accessible when Google Analytics is not installed #30481

Manual testing scenarios (*)

  1. With the develop branch checked out, go to Config > Sales > Google API > Google AdWords. Configure some values and take note of them.
  2. Check out this branch.
  3. In composer.json, replace google analytics so that module is removed (see steps to reproduce in related issue).
  4. Run composer install and flush cache.
  5. In admin, confirm that Google AdWords config is accessible in Config > Sales > Google AdWords > Google AdWords and the previously configured test values are present.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…e independent of google analytics. Rename google analytics config for clarity.
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2021

Hi @zaximus84. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Google Adwords menu items are not accessible when Google Analytics is not installed
2 participants