Magento REST API returns not existing SKU when custom option was set #25461

[engcom-Hotel]

Description (*)

Fix for the API response at the quote for products SKU without options.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/411

Fixed Issues (if relevant)

1. Fixes Magento REST API returns not existing SKU when custom option was set #25461

Manual testing scenarios (*)

#25461

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Hotel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Hotel]

Recreated from #30430

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests CE, Functional Tests EE

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[engcom-Bravo]

❌ QA Failed

According to the Expected result from the issue #25461, You should have an ability to get real product SKU
It doesn't work correctly with Configurable product.
In this particular case, displayed on the screenshot, I would expect to get the SKU of the simple product - Configurable 2-Red, not the SKU of the main Configurable product

@ihor-sviziev What do you think about this?

[engcom-Hotel]

@magento run Functional Tests CE

[engcom-Hotel]

Hi @engcom-Bravo,
Good point.
Probably we may add such approach for bundle products.
As a result, we will have additional information about the products which were actually added to the cart.
Due to that bundle may have several products, it is better to keep the original SKU as an array.
Example of the response:

0: {item_id: 1, sku: "Simple-1-Red", original_product_sku: "Simple-1", qty: 1, name: "Simple-1", …}
1: {item_id: 2, sku: "Configurable 2-a-Green", original_product_sku: "Configurable 2-a", qty: 1, name: "Configurable 2", …}
2:
item_id: 14
name: "Bundle-3"
original_product_sku: ["Configurable 2-b"]
price: 77777
product_type: "bundle"
qty: 1
quote_id: "1"
sku: "Bundle-3-Configurable 2-b"
__proto__: Object
3:
item_id: 16
name: "Bundle-4"
original_product_sku: (2) ["Configurable 2-a", "Configurable 2-b"]
price: 155554
product_type: "bundle"
qty: 1
quote_id: "1"
sku: "Bundle-4-Configurable 2-a-Configurable 2-b"
__proto__: Object
length: 4
__proto__: Array(0)

@ihor-sviziev @gabrieldagama What do you think?

[ihor-sviziev]

@engcom-Hotel looks good to me.

[engcom-Hotel]

Moved on hold until workflow for 2.5 version release.

[engcom-Hotel]

Not finished yet, please feel free to continue.