Fix #29971 - Layered navigation swatches ignore show tooltip setting #30115

Bartlomiejsz · 2020-09-19T09:40:09Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Layered navigation swatches ignore show tooltip setting #29971

Manual testing scenarios (*)

Please check fixed issue for testing scenario

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-09-19T09:40:12Z

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Bartlomiejsz · 2020-09-19T10:32:54Z

@magento run all tests

Bartlomiejsz · 2020-09-19T12:15:31Z

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

Bartlomiejsz · 2020-09-19T14:23:30Z

@magento run Functional Tests EE

rogyar · 2020-09-19T15:14:55Z

Hi @Bartlomiejsz. Thank you for your contribution. Could I ask you to create an integration/functional test for this case, please? The test will set all the preconditions and assert that the page source does not have the tooltip selector.

Thank you!

Bartlomiejsz · 2020-09-19T15:27:40Z

Hi @rogyar, I believe I can work on it in the upcoming days

…etting

sidolov

@Bartlomiejsz could you please cover changes with automated test?

sidolov · 2020-10-02T18:53:28Z

app/code/Magento/Swatches/Model/Plugin/FilterRenderer.php

     */
-    protected $block = \Magento\Swatches\Block\LayeredNavigation\RenderLayered::class;
+    protected $swatchHelper;


Make property private

sidolov · 2020-10-02T18:54:03Z

app/code/Magento/Swatches/Model/Plugin/FilterRenderer.php

    ) {
        $this->layout = $layout;
        $this->swatchHelper = $swatchHelper;
+        $this->configurableViewModel = $configurableViewModel


You may not follow BC development rules in plugins.

Bartlomiejsz · 2020-10-02T18:56:51Z

Hi @sidolov, yes, I will work on that, just didn't yet have time for it unfortunately

…h_tooltip

Bartlomiejsz · 2020-10-06T12:41:36Z

@magento run all tests

Bartlomiejsz · 2020-10-06T14:08:26Z

@magento run Functional Tests CE

Bartlomiejsz · 2020-10-06T14:22:49Z

@magento run WebAPI Tests

rogyar · 2020-10-09T14:24:49Z

...ode/Magento/Catalog/Test/Mftf/ActionGroup/AdminAssignCategoryToProductAndSaveActionGroup.xml

-        <checkOption selector="{{AdminProductFormSection.selectCategory(categoryName)}}" stepKey="selectCategory"/>
-        <click selector="{{AdminProductFormSection.done}}" stepKey="clickDone"/>
-        <waitForPageLoad stepKey="waitForApplyCategory"/>
+    <actionGroup name="AdminAssignCategoryToProductAndSaveActionGroup" extends="AdminAssignCategoryToProductActionGroup">


That's a very good cleanup. But unfortunately, it makes the PR backward-incompatible for 2.4-develop branch. There might be 3rd-party modules that extend the current action group and rely on the step keys. By removing the existing step keys we may brake such systems

rogyar · 2020-10-09T14:27:09Z

app/code/Magento/Swatches/Test/Mftf/Test/AdminDisablingSwatchTooltipsTest.xml

            <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
        </before>
        <after>
-            <!-- Clean up our modifications to the existing color attribute -->


Here as well, if we remove the existing step keys, we introduce backward-incompatible changes.

rogyar · 2020-10-09T14:29:30Z

Hi @Bartlomiejsz. Awesome job! Thank you.
I left some comments regarding backward compatibility. But it will be a shame to discard your refactorings because of that fact. I would go the following way. We may have the 2.5-develop branch soon. Once it's available, I would suggest you recreate the same PR into the 2.5-develop branch. In that way, we will not be afraid of backward compatibility.

How does it sound?

Bartlomiejsz · 2020-10-09T15:20:39Z

@rogyar that sounds good to me, just wondering - is it known already when 2.5 branch will be available?

rogyar · 2020-10-13T06:00:08Z

Hi @Bartlomiejsz. We have not publicly available info about that point so far

ghost added the Progress: pending review label Sep 19, 2020

magento-engcom-team added Area: Frontend Component: Swatches Release Line: 2.4 Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Sep 19, 2020

Bartlomiejsz force-pushed the bugfix/29971_layered_navigation_swatch_tooltip branch from 20664cb to 81cda6f Compare September 19, 2020 10:32

rogyar self-assigned this Sep 19, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 21, 2020

Fix magento#29971 - Layered navigation swatches ignore show tooltip s…

5599cdd

…etting

Bartlomiejsz force-pushed the bugfix/29971_layered_navigation_swatch_tooltip branch from 81cda6f to 5599cdd Compare September 22, 2020 09:44

sidolov added the Progress: review label Oct 1, 2020

ghost removed the Progress: pending review label Oct 1, 2020

sidolov requested changes Oct 2, 2020

View reviewed changes

ghost assigned sidolov Oct 2, 2020

ghost added Progress: needs update and removed Progress: review labels Oct 2, 2020

Merge branch '2.4-develop' into bugfix/29971_layered_navigation_swatc…

7722d58

…h_tooltip

Bartlomiejsz force-pushed the bugfix/29971_layered_navigation_swatch_tooltip branch from b5397d2 to 5fe0d4a Compare October 6, 2020 12:40

Bartlomiejsz force-pushed the bugfix/29971_layered_navigation_swatch_tooltip branch from 5fe0d4a to 354ec22 Compare October 6, 2020 12:41

Bartlomiejsz requested a review from sidolov October 6, 2020 16:32

ghost assigned Bartlomiejsz Oct 7, 2020

rogyar reviewed Oct 9, 2020

View reviewed changes

sidolov added this to the 2.5 milestone Nov 11, 2020

m2-community-project bot removed the Progress: needs update label Nov 11, 2020

m2-community-project bot added Progress: review Progress: on hold Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Progress: review labels Nov 11, 2020

m2-community-project bot added Progress: review and removed Progress: on hold labels Nov 13, 2020

Bartlomiejsz changed the base branch from 2.4-develop to 2.5-develop January 11, 2021 23:41

gabrieldagama added the up for grabs label Jan 22, 2021

gabrieldagama removed the up for grabs label Jan 22, 2021

gabrieldagama added Release Line: 2.5 and removed Release Line: 2.4 labels Mar 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #29971 - Layered navigation swatches ignore show tooltip setting #30115

Fix #29971 - Layered navigation swatches ignore show tooltip setting #30115

Bartlomiejsz commented Sep 19, 2020 •

edited

Loading

m2-assistant bot commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

rogyar commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

sidolov left a comment

sidolov Oct 2, 2020

Bartlomiejsz Oct 7, 2020

sidolov Oct 2, 2020

Bartlomiejsz Oct 7, 2020

Bartlomiejsz commented Oct 2, 2020

Bartlomiejsz commented Oct 6, 2020

Bartlomiejsz commented Oct 6, 2020

Bartlomiejsz commented Oct 6, 2020

rogyar Oct 9, 2020

rogyar Oct 9, 2020

rogyar commented Oct 9, 2020

Bartlomiejsz commented Oct 9, 2020

rogyar commented Oct 13, 2020

Fix #29971 - Layered navigation swatches ignore show tooltip setting #30115

Are you sure you want to change the base?

Fix #29971 - Layered navigation swatches ignore show tooltip setting #30115

Conversation

Bartlomiejsz commented Sep 19, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

rogyar commented Sep 19, 2020

Bartlomiejsz commented Sep 19, 2020

sidolov left a comment

Choose a reason for hiding this comment

sidolov Oct 2, 2020

Choose a reason for hiding this comment

Bartlomiejsz Oct 7, 2020

Choose a reason for hiding this comment

sidolov Oct 2, 2020

Choose a reason for hiding this comment

Bartlomiejsz Oct 7, 2020

Choose a reason for hiding this comment

Bartlomiejsz commented Oct 2, 2020

Bartlomiejsz commented Oct 6, 2020

Bartlomiejsz commented Oct 6, 2020

Bartlomiejsz commented Oct 6, 2020

rogyar Oct 9, 2020

Choose a reason for hiding this comment

rogyar Oct 9, 2020

Choose a reason for hiding this comment

rogyar commented Oct 9, 2020

Bartlomiejsz commented Oct 9, 2020

rogyar commented Oct 13, 2020

Bartlomiejsz commented Sep 19, 2020 •

edited

Loading